Commit 85992b65 authored by Zentaro Kavanagh's avatar Zentaro Kavanagh Committed by Commit Bot

Mark classes with final dtors as final

- -Wfinal-dtor-non-final-class warns on classes with final dtors but
  not final classes.
- Error messages are better when the class is marked final.
- Fix existing issues in code base and remove warning exemption

Bug: chromium:999886
Test: no errors building
Change-Id: Ied2a7a2ff890ecbaf0a4c84f5323f0c9d32def58
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2467000Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70509}
parent 0af542c8
...@@ -331,7 +331,7 @@ class UnbufferedCharacterStream : public Utf16CharacterStream { ...@@ -331,7 +331,7 @@ class UnbufferedCharacterStream : public Utf16CharacterStream {
// Provides a unbuffered utf-16 view on the bytes from the underlying // Provides a unbuffered utf-16 view on the bytes from the underlying
// ByteStream. // ByteStream.
class RelocatingCharacterStream class RelocatingCharacterStream final
: public UnbufferedCharacterStream<OnHeapStream> { : public UnbufferedCharacterStream<OnHeapStream> {
public: public:
template <class... TArgs> template <class... TArgs>
...@@ -422,7 +422,7 @@ bool BufferedUtf16CharacterStream::ReadBlock() { ...@@ -422,7 +422,7 @@ bool BufferedUtf16CharacterStream::ReadBlock() {
// TODO(verwaest): Decode utf8 chunks into utf16 chunks on the blink side // TODO(verwaest): Decode utf8 chunks into utf16 chunks on the blink side
// instead so we don't need to buffer. // instead so we don't need to buffer.
class Utf8ExternalStreamingStream : public BufferedUtf16CharacterStream { class Utf8ExternalStreamingStream final : public BufferedUtf16CharacterStream {
public: public:
Utf8ExternalStreamingStream( Utf8ExternalStreamingStream(
ScriptCompiler::ExternalSourceStream* source_stream) ScriptCompiler::ExternalSourceStream* source_stream)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment