Commit 8534e52d authored by Victor Gomes's avatar Victor Gomes Committed by Commit Bot

[compiler] Fallback to slow path for any unexpected opcode in TryGetScopeInfo

The bug is due to an unexpected opcode. To avoid similar issues in the future, we fallback to CheckContextExtensionSlowPath. This was the default behaviour before the CL (https://chromium-review.googlesource.com/c/v8/v8/+/1876051).

Bug: chromium:1020983
Change-Id: Ia7f0f2986ec0008d1128ad3856efbb5d9e52dfc6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1899989
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64794}
parent fbcc2e87
...@@ -1616,14 +1616,8 @@ base::Optional<ScopeInfoRef> BytecodeGraphBuilder::TryGetScopeInfo() { ...@@ -1616,14 +1616,8 @@ base::Optional<ScopeInfoRef> BytecodeGraphBuilder::TryGetScopeInfo() {
} }
return scope_info; return scope_info;
} }
case IrOpcode::kJSGeneratorRestoreContext:
case IrOpcode::kOsrValue:
case IrOpcode::kPhi:
// For a large context, the runtime call is still used.
case IrOpcode::kJSCallRuntime:
return base::nullopt;
default: default:
UNREACHABLE(); return base::nullopt;
} }
} }
......
// Copyright 2019 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --always-osr
function opt() {
for (let i = 0; i < 5000; i++) {
try {
try {
throw 1
} finally {
E
}
} catch {}
}
eval()
}
opt()
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment