Commit 84d07481 authored by Milad Fa's avatar Milad Fa Committed by V8 LUCI CQ

[wasm] Fix compilation on gcc

This CL fixed the following compilation error:
```
error: inline declaration of 'Union(...)' follows declaration with attribute 'noinline'
```

Change-Id: I9672ca89d245e5f018f7dada57e30be1fc170115
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3673194Reviewed-by: 's avatarManos Koukoutos <manoskouk@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Cr-Commit-Position: refs/heads/main@{#80822}
parent b4666dbc
......@@ -383,10 +383,9 @@ HeapType::Representation CommonAncestorWithGeneric(HeapType heap1,
}
} // namespace
V8_NOINLINE V8_EXPORT_PRIVATE TypeInModule Union(ValueType type1,
ValueType type2,
const WasmModule* module1,
const WasmModule* module2) {
V8_EXPORT_PRIVATE TypeInModule Union(ValueType type1, ValueType type2,
const WasmModule* module1,
const WasmModule* module2) {
if (!type1.is_object_reference() || !type2.is_object_reference()) {
return {
EquivalentTypes(type1, type2, module1, module2) ? type1 : kWasmBottom,
......
......@@ -126,19 +126,18 @@ inline std::ostream& operator<<(std::ostream& oss, TypeInModule type) {
<< reinterpret_cast<intptr_t>(type.module);
}
V8_NOINLINE V8_EXPORT_PRIVATE TypeInModule Union(ValueType type1,
ValueType type2,
const WasmModule* module1,
const WasmModule* module2);
V8_EXPORT_PRIVATE TypeInModule Union(ValueType type1, ValueType type2,
const WasmModule* module1,
const WasmModule* module2);
V8_INLINE V8_EXPORT_PRIVATE TypeInModule Union(TypeInModule type1,
TypeInModule type2) {
return Union(type1.type, type2.type, type1.module, type2.module);
}
V8_NOINLINE V8_EXPORT_PRIVATE TypeInModule
Intersection(ValueType type1, ValueType type2, const WasmModule* module1,
const WasmModule* module2);
V8_EXPORT_PRIVATE TypeInModule Intersection(ValueType type1, ValueType type2,
const WasmModule* module1,
const WasmModule* module2);
V8_INLINE V8_EXPORT_PRIVATE TypeInModule Intersection(TypeInModule type1,
TypeInModule type2) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment