Commit 84c937b7 authored by Anton Bikineev's avatar Anton Bikineev Committed by V8 LUCI CQ

cppgc: Fix "#if" directive in logging.h

The macro may be defined but the value to it may not be assigned. The
compiler can complain about (reproduced when compiling chromium on
Windows).

Bug: chromium:1249550
Change-Id: I684997ccda7122f56c01391e7a1339fadf6589e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3297888Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/main@{#78040}
parent a68aa672
...@@ -20,18 +20,18 @@ FatalImpl(const char*, const SourceLocation& = SourceLocation::Current()); ...@@ -20,18 +20,18 @@ FatalImpl(const char*, const SourceLocation& = SourceLocation::Current());
template <typename> template <typename>
struct EatParams {}; struct EatParams {};
#if DEBUG #if defined(DEBUG)
#define CPPGC_DCHECK_MSG(condition, message) \ #define CPPGC_DCHECK_MSG(condition, message) \
do { \ do { \
if (V8_UNLIKELY(!(condition))) { \ if (V8_UNLIKELY(!(condition))) { \
::cppgc::internal::DCheckImpl(message); \ ::cppgc::internal::DCheckImpl(message); \
} \ } \
} while (false) } while (false)
#else #else // !defined(DEBUG)
#define CPPGC_DCHECK_MSG(condition, message) \ #define CPPGC_DCHECK_MSG(condition, message) \
(static_cast<void>(::cppgc::internal::EatParams<decltype( \ (static_cast<void>(::cppgc::internal::EatParams<decltype( \
static_cast<void>(condition), message)>{})) static_cast<void>(condition), message)>{}))
#endif #endif // !defined(DEBUG)
#define CPPGC_DCHECK(condition) CPPGC_DCHECK_MSG(condition, #condition) #define CPPGC_DCHECK(condition) CPPGC_DCHECK_MSG(condition, #condition)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment