Commit 8441f26c authored by Leon Bettscheider's avatar Leon Bettscheider Committed by V8 LUCI CQ

[heap] Bailout in IncrementalMarkingJob::ScheduleTask

Currently MinorMC does not suport incremental marking but uses the
IncrementalMarking class to bootstrap concurrent marking.

IncrementalMarkingJob::ScheduleTask is called from multiple call
sites which assume major incremental marking. This CL adds a bailout
to ScheduleTask on IsMajorMarking()==false to avoid erreoneously
doing incremental steps while in MinorMC mode.

Bug: v8:13012
Change-Id: I57803a8f258697478a9696716063c8c2cae1ae30
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865147Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
Commit-Queue: Leon Bettscheider <bettscheider@google.com>
Cr-Commit-Position: refs/heads/main@{#82891}
parent d1e696d0
......@@ -41,7 +41,8 @@ void IncrementalMarkingJob::ScheduleTask() {
base::MutexGuard guard(&mutex_);
if (is_task_pending_ || heap_->IsTearingDown() ||
!FLAG_incremental_marking_task) {
!FLAG_incremental_marking_task ||
!heap_->incremental_marking()->IsMajorMarking()) {
return;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment