Commit 841fd707 authored by Milad Farazmand's avatar Milad Farazmand Committed by Commit Bot

PPC: [codegen][cleanup] Unify assembler's support for DebugBreak().

Port 86d4b9f6

Original Commit Message:

    Each assembler has it's own way to place breakpoints:

      - stop() for arm, mips*, ppc* and s390.
      - debug() for arm64.
      - int3() for ia32 and x64.

    We can mandate a macro-assembler `DebugBreak()` method that all should
    implement so one can place a breakpoint in a portable way using a
    macro-assembler. This way also assemblers are in line with TurboFan, CSA, Torque
    and Liftoff which all have a DebugBreak() facility.

R=pierre.langlois@arm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Change-Id: If2fb5ed99b4477142579e29fc5288d0768fd48c7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2047463Reviewed-by: 's avatarJunliang Yan <jyan@ca.ibm.com>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#66207}
parent 9d3dc6f2
......@@ -764,7 +764,6 @@ class V8_EXPORT_PRIVATE MacroAssembler : public TurboAssembler {
void InvokeFunction(Register function, Register expected_parameter_count,
Register actual_parameter_count, InvokeFlag flag);
void DebugBreak();
// Frame restart support
void MaybeDropFrames();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment