Commit 83b28cd1 authored by whesse@chromium.org's avatar whesse@chromium.org

Avoid comparing a pointer-to-member to NULL, even though C++ is supposed to support it.

Review URL: http://codereview.chromium.org/5988001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6064 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 9f1bcdf8
...@@ -671,8 +671,12 @@ const FullCodeGenerator::InlineFunctionGenerator ...@@ -671,8 +671,12 @@ const FullCodeGenerator::InlineFunctionGenerator
FullCodeGenerator::InlineFunctionGenerator FullCodeGenerator::InlineFunctionGenerator
FullCodeGenerator::FindInlineFunctionGenerator(Runtime::FunctionId id) { FullCodeGenerator::FindInlineFunctionGenerator(Runtime::FunctionId id) {
return kInlineFunctionGenerators[ int lookup_index =
static_cast<int>(id) - static_cast<int>(Runtime::kFirstInlineFunction)]; static_cast<int>(id) - static_cast<int>(Runtime::kFirstInlineFunction);
ASSERT(lookup_index >= 0);
ASSERT(static_cast<size_t>(lookup_index) <
ARRAY_SIZE(kInlineFunctionGenerators));
return kInlineFunctionGenerators[lookup_index];
} }
...@@ -684,7 +688,6 @@ void FullCodeGenerator::EmitInlineRuntimeCall(CallRuntime* node) { ...@@ -684,7 +688,6 @@ void FullCodeGenerator::EmitInlineRuntimeCall(CallRuntime* node) {
ASSERT(function->intrinsic_type == Runtime::INLINE); ASSERT(function->intrinsic_type == Runtime::INLINE);
InlineFunctionGenerator generator = InlineFunctionGenerator generator =
FindInlineFunctionGenerator(function->function_id); FindInlineFunctionGenerator(function->function_id);
ASSERT(generator != NULL);
((*this).*(generator))(args); ((*this).*(generator))(args);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment