VectorICs: built-in function apply should use an IC.

Handled a TODO that sent builtin function apply to the runtime on property get.

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1120613002

Cr-Commit-Position: refs/heads/master@{#28165}

src/bootstrapper.cc

@@ -1731,18 +1731,6 @@ void Genesis::InitializeGlobal_harmony_reflect() {
     Handle<JSFunction> construct = InstallFunction(
         builtins, "$reflectConstruct", JS_OBJECT_TYPE, JSObject::kHeaderSize,
         MaybeHandle<JSObject>(), Builtins::kReflectConstruct);
-    if (FLAG_vector_ics) {
-      // Apply embeds an IC, so we need a type vector of size 1 in the shared
-      // function info.
-      FeedbackVectorSpec spec(0, Code::CALL_IC);
-      Handle<TypeFeedbackVector> feedback_vector =
-          factory()->NewTypeFeedbackVector(&spec);
-      apply->shared()->set_feedback_vector(*feedback_vector);
-
-      feedback_vector = factory()->NewTypeFeedbackVector(&spec);
-      construct->shared()->set_feedback_vector(*feedback_vector);
-    }
-
     apply->shared()->set_internal_formal_parameter_count(3);
     apply->shared()->set_length(3);
 
@@ -2181,14 +2169,6 @@ bool Genesis::InstallNatives() {
     Handle<JSFunction> apply =
         InstallFunction(proto, "apply", JS_OBJECT_TYPE, JSObject::kHeaderSize,
                         MaybeHandle<JSObject>(), Builtins::kFunctionApply);
-    if (FLAG_vector_ics) {
-      // Apply embeds an IC, so we need a type vector of size 1 in the shared
-      // function info.
-      FeedbackVectorSpec spec(0, Code::CALL_IC);
-      Handle<TypeFeedbackVector> feedback_vector =
-          factory()->NewTypeFeedbackVector(&spec);
-      apply->shared()->set_feedback_vector(*feedback_vector);
-    }
 
     // Make sure that Function.prototype.call appears to be compiled.
     // The code will never be called, but inline caching for call will

src/ia32/builtins-ia32.cc

@@ -1057,21 +1057,13 @@ static void Generate_PushAppliedArguments(MacroAssembler* masm,
   __ bind(&loop);
   __ mov(receiver, Operand(ebp, argumentsOffset));  // load arguments
 
-  if (FLAG_vector_ics) {
-    // TODO(mvstanton): Vector-based ics need additional infrastructure to
-    // be embedded here. For now, just call the runtime.
-    __ push(receiver);
-    __ push(key);
-    __ CallRuntime(Runtime::kGetProperty, 2);
-  } else {
-    // Use inline caching to speed up access to arguments.
-    Handle<Code> ic = CodeFactory::KeyedLoadIC(masm->isolate()).code();
-    __ call(ic, RelocInfo::CODE_TARGET);
-    // It is important that we do not have a test instruction after the
-    // call.  A test instruction after the call is used to indicate that
-    // we have generated an inline version of the keyed load.  In this
-    // case, we know that we are not generating a test instruction next.
-  }
+  // Use inline caching to speed up access to arguments.
+  Handle<Code> ic = masm->isolate()->builtins()->KeyedLoadIC_Megamorphic();
+  __ call(ic, RelocInfo::CODE_TARGET);
+  // It is important that we do not have a test instruction after the
+  // call.  A test instruction after the call is used to indicate that
+  // we have generated an inline version of the keyed load.  In this
+  // case, we know that we are not generating a test instruction next.
 
   // Push the nth argument.
   __ push(eax);

src/x64/builtins-x64.cc

@@ -1122,20 +1122,12 @@ static void Generate_PushAppliedArguments(MacroAssembler* masm,
   __ movp(receiver, Operand(rbp, argumentsOffset));  // load arguments
 
   // Use inline caching to speed up access to arguments.
-  if (FLAG_vector_ics) {
-    // TODO(mvstanton): Vector-based ics need additional infrastructure to
-    // be embedded here. For now, just call the runtime.
-    __ Push(receiver);
-    __ Push(key);
-    __ CallRuntime(Runtime::kGetProperty, 2);
-  } else {
-    Handle<Code> ic = CodeFactory::KeyedLoadIC(masm->isolate()).code();
-    __ Call(ic, RelocInfo::CODE_TARGET);
-    // It is important that we do not have a test instruction after the
-    // call.  A test instruction after the call is used to indicate that
-    // we have generated an inline version of the keyed load.  In this
-    // case, we know that we are not generating a test instruction next.
-  }
+  Handle<Code> ic = masm->isolate()->builtins()->KeyedLoadIC_Megamorphic();
+  __ Call(ic, RelocInfo::CODE_TARGET);
+  // It is important that we do not have a test instruction after the
+  // call.  A test instruction after the call is used to indicate that
+  // we have generated an inline version of the keyed load.  In this
+  // case, we know that we are not generating a test instruction next.
 
   // Push the nth argument.
   __ Push(rax);