Commit 837760ec authored by adamk's avatar adamk Committed by Commit bot

Remove tiny unit test for MinSimple/MaxSimple

The source code of those functions is simple a ternary operator, and
the test seems to have been designed as a "regression" test for the
previous implementation (which used a macro, and thus evaluated its
arguments multiple times).

I don't think the test is worth the weight of supporting importing
JS natives from tests.

This patch removes the last test that depends on JS natives.

R=littledan@chromium.org

Review-Url: https://codereview.chromium.org/2711833002
Cr-Commit-Position: refs/heads/master@{#43394}
parent 184e80a6
...@@ -170,8 +170,6 @@ function PostNatives(utils) { ...@@ -170,8 +170,6 @@ function PostNatives(utils) {
"FormatDateToParts", "FormatDateToParts",
"MapEntries", "MapEntries",
"MapIteratorNext", "MapIteratorNext",
"MaxSimple",
"MinSimple",
"SetIteratorNext", "SetIteratorNext",
"SetValues", "SetValues",
"ToLocaleLowerCaseI18N", "ToLocaleLowerCaseI18N",
......
// Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --expose-natives-as natives
// Test the MaxSimple and MinSimple internal methods in runtime.js
var MaxSimple = natives.ImportNow("MaxSimple");
var MinSimple = natives.ImportNow("MinSimple");
function checkEvaluations(target) {
var evaluations = 0;
var observedNumber = {
valueOf: function() {
evaluations++;
return 0;
}
};
target(observedNumber, observedNumber);
return evaluations;
}
assertEquals(1, MaxSimple(-1, 1));
assertEquals(2, checkEvaluations(MaxSimple));
assertEquals(-1, MinSimple(-1, 1));
assertEquals(2, checkEvaluations(MinSimple));
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment