Commit 8358094d authored by Shu-yu Guo's avatar Shu-yu Guo Committed by Commit Bot

[atomics] Missing detach check in Atomics.store on MIPS

There was a missing detach check in the runtime implementation of
Atomics.store on BigInt TypedArrays. This runtime function is only used
on MIPS.

Bug: v8:10687
Change-Id: I77946d2ab0abf70c583af514ddaba0d384a21309
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2369663
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Ben Smith <binji@chromium.org>
Reviewed-by: 's avatarBen Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69525}
parent e8a5793a
...@@ -437,9 +437,10 @@ RUNTIME_FUNCTION(Runtime_AtomicsStore64) { ...@@ -437,9 +437,10 @@ RUNTIME_FUNCTION(Runtime_AtomicsStore64) {
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, bigint, ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, bigint,
BigInt::FromObject(isolate, value_obj)); BigInt::FromObject(isolate, value_obj));
THROW_ERROR_RETURN_FAILURE_ON_DETACHED(isolate, sta, "Atomics.store");
DCHECK(sta->type() == kExternalBigInt64Array || DCHECK(sta->type() == kExternalBigInt64Array ||
sta->type() == kExternalBigUint64Array); sta->type() == kExternalBigUint64Array);
DCHECK(!sta->WasDetached());
CHECK_LT(index, sta->length()); CHECK_LT(index, sta->length());
if (sta->type() == kExternalBigInt64Array) { if (sta->type() == kExternalBigInt64Array) {
Store<int64_t>::Do(isolate, source, index, bigint); Store<int64_t>::Do(isolate, source, index, bigint);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment