[compiler] Remove Handle uses from access-info signatures

All these methods are called in compiler/concurrent contexts and
should therefore use refs where possible. This mostly just pushes code
around, but does avoid a few completely unnecessary ref-handle-ref
round-trips.

Bug: v8:7790
Change-Id: I18e6f45ddcd16373b5349bdb7d2dccd205f5c9ef
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3038522Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75814}

src/compiler/access-info.h

@@ -5,14 +5,8 @@
 #ifndef V8_COMPILER_ACCESS_INFO_H_
 #define V8_COMPILER_ACCESS_INFO_H_
 
-#include <iosfwd>
-
-#include "src/codegen/machine-type.h"
+#include "src/compiler/heap-refs.h"
 #include "src/compiler/types.h"
-#include "src/objects/feedback-vector.h"
-#include "src/objects/field-index.h"
-#include "src/objects/map.h"
-#include "src/objects/objects.h"
 #include "src/zone/zone-containers.h"
 
 namespace v8 {
@@ -252,28 +246,22 @@ class AccessInfoFactory final {
                     Zone* zone);
 
   base::Optional<ElementAccessInfo> ComputeElementAccessInfo(
-      Handle<Map> map, AccessMode access_mode) const;
+      MapRef map, AccessMode access_mode) const;
   bool ComputeElementAccessInfos(
       ElementAccessFeedback const& feedback,
       ZoneVector<ElementAccessInfo>* access_infos) const;
 
-  PropertyAccessInfo ComputePropertyAccessInfo(Handle<Map> map,
-                                               Handle<Name> name,
+  PropertyAccessInfo ComputePropertyAccessInfo(MapRef map, NameRef name,
                                                AccessMode access_mode) const;
 
   PropertyAccessInfo ComputeDictionaryProtoAccessInfo(
-      Handle<Map> receiver_map, Handle<Name> name, Handle<JSObject> holder,
+      MapRef receiver_map, NameRef name, JSObjectRef holder,
       InternalIndex dict_index, AccessMode access_mode,
       PropertyDetails details) const;
 
   MinimorphicLoadPropertyAccessInfo ComputePropertyAccessInfo(
       MinimorphicLoadPropertyAccessFeedback const& feedback) const;
 
-  // Convenience wrapper around {ComputePropertyAccessInfo} for multiple maps.
-  void ComputePropertyAccessInfos(
-      MapHandles const& maps, Handle<Name> name, AccessMode access_mode,
-      ZoneVector<PropertyAccessInfo>* access_infos) const;
-
   // Merge as many of the given {infos} as possible and record any dependencies.
   // Return false iff any of them was invalid, in which case no dependencies are
   // recorded.
@@ -291,18 +279,15 @@ class AccessInfoFactory final {
  private:
   base::Optional<ElementAccessInfo> ConsolidateElementLoad(
       ElementAccessFeedback const& feedback) const;
-  PropertyAccessInfo LookupSpecialFieldAccessor(Handle<Map> map,
-                                                Handle<Name> name) const;
-  PropertyAccessInfo LookupTransition(Handle<Map> map, Handle<Name> name,
-                                      MaybeHandle<JSObject> holder) const;
-  PropertyAccessInfo ComputeDataFieldAccessInfo(Handle<Map> receiver_map,
-                                                Handle<Map> map,
-                                                MaybeHandle<JSObject> holder,
-                                                InternalIndex descriptor,
-                                                AccessMode access_mode) const;
+  PropertyAccessInfo LookupSpecialFieldAccessor(MapRef map, NameRef name) const;
+  PropertyAccessInfo LookupTransition(MapRef map, NameRef name,
+                                      base::Optional<JSObjectRef> holder) const;
+  PropertyAccessInfo ComputeDataFieldAccessInfo(
+      MapRef receiver_map, MapRef map, base::Optional<JSObjectRef> holder,
+      InternalIndex descriptor, AccessMode access_mode) const;
   PropertyAccessInfo ComputeAccessorDescriptorAccessInfo(
-      Handle<Map> receiver_map, Handle<Name> name, Handle<Map> map,
-      MaybeHandle<JSObject> holder, InternalIndex descriptor,
+      MapRef receiver_map, NameRef name, MapRef map,
+      base::Optional<JSObjectRef> holder, InternalIndex descriptor,
       AccessMode access_mode) const;
 
   PropertyAccessInfo Invalid() const {
@@ -313,8 +298,9 @@ class AccessInfoFactory final {
                                 AccessMode access_mode,
                                 ZoneVector<PropertyAccessInfo>* result) const;
 
-  bool TryLoadPropertyDetails(Handle<Map> map, MaybeHandle<JSObject> holder,
-                              Handle<Name> name, InternalIndex* index_out,
+  bool TryLoadPropertyDetails(MapRef map,
+                              base::Optional<JSObjectRef> maybe_holder,
+                              NameRef name, InternalIndex* index_out,
                               PropertyDetails* details_out) const;
 
   CompilationDependencies* dependencies() const { return dependencies_; }
@@ -327,7 +313,6 @@ class AccessInfoFactory final {
   TypeCache const* const type_cache_;
   Zone* const zone_;
 
-  // TODO(nicohartmann@): Move to public
   AccessInfoFactory(const AccessInfoFactory&) = delete;
   AccessInfoFactory& operator=(const AccessInfoFactory&) = delete;
 };

src/compiler/js-call-reducer.cc

@@ -7979,20 +7979,15 @@ Reduction JSCallReducer::ReduceRegExpPrototypeTest(Node* node) {
   ZoneVector<PropertyAccessInfo> access_infos(graph()->zone());
   AccessInfoFactory access_info_factory(broker(), dependencies(),
                                         graph()->zone());
-  if (broker()->is_concurrent_inlining()) {
-    // Obtain precomputed access infos from the broker.
-    for (auto map : regexp_maps) {
-      MapRef map_ref = MakeRef(broker(), map);
-      PropertyAccessInfo access_info = broker()->GetPropertyAccessInfo(
-          map_ref, MakeRef(broker(), isolate()->factory()->exec_string()),
-          AccessMode::kLoad, dependencies());
-      access_infos.push_back(access_info);
-    }
-  } else {
-    // Compute property access info for "exec" on {resolution}.
-    access_info_factory.ComputePropertyAccessInfos(
-        MapHandles(regexp_maps.begin(), regexp_maps.end()),
-        factory()->exec_string(), AccessMode::kLoad, &access_infos);
+
+  for (auto map : regexp_maps) {
+    access_infos.push_back(broker()->GetPropertyAccessInfo(
+        MakeRef(broker(), map),
+        MakeRef(broker(), isolate()->factory()->exec_string()),
+        AccessMode::kLoad, dependencies(),
+        broker()->is_concurrent_inlining()
+            ? SerializationPolicy::kAssumeSerialized
+            : SerializationPolicy::kSerializeIfNeeded));
   }
 
   PropertyAccessInfo ai_exec =

src/compiler/js-heap-broker.cc

@@ -1078,8 +1078,8 @@ PropertyAccessInfo JSHeapBroker::GetPropertyAccessInfo(
 
   CHECK_NOT_NULL(dependencies);
   AccessInfoFactory factory(this, dependencies, zone());
-  PropertyAccessInfo access_info = factory.ComputePropertyAccessInfo(
-      map.object(), name.object(), access_mode);
+  PropertyAccessInfo access_info =
+      factory.ComputePropertyAccessInfo(map, name, access_mode);
   if (is_concurrent_inlining_) {
     CHECK_IMPLIES(!FLAG_turbo_concurrent_get_property_access_info,
                   mode() == kSerializing);

src/compiler/js-native-context-specialization.cc

@@ -408,20 +408,12 @@ Reduction JSNativeContextSpecialization::ReduceJSInstanceOf(Node* node) {
 
   JSObjectRef receiver_ref = MakeRef(broker(), receiver);
   MapRef receiver_map = receiver_ref.map();
-
-  PropertyAccessInfo access_info = PropertyAccessInfo::Invalid(graph()->zone());
-  if (broker()->is_concurrent_inlining()) {
-    access_info = broker()->GetPropertyAccessInfo(
-        receiver_map,
-        MakeRef(broker(), isolate()->factory()->has_instance_symbol()),
-        AccessMode::kLoad, dependencies());
-  } else {
-    AccessInfoFactory access_info_factory(broker(), dependencies(),
-                                          graph()->zone());
-    access_info = access_info_factory.ComputePropertyAccessInfo(
-        receiver_map.object(), factory()->has_instance_symbol(),
-        AccessMode::kLoad);
-  }
+  NameRef name = MakeRef(broker(), isolate()->factory()->has_instance_symbol());
+  PropertyAccessInfo access_info = broker()->GetPropertyAccessInfo(
+      receiver_map, name, AccessMode::kLoad, dependencies(),
+      broker()->is_concurrent_inlining()
+          ? SerializationPolicy::kAssumeSerialized
+          : SerializationPolicy::kSerializeIfNeeded);
 
   // TODO(v8:11457) Support dictionary mode holders here.
   if (access_info.IsInvalid() || access_info.HasDictionaryHolder()) {
@@ -724,18 +716,15 @@ Reduction JSNativeContextSpecialization::ReduceJSResolvePromise(Node* node) {
   ZoneVector<PropertyAccessInfo> access_infos(graph()->zone());
   AccessInfoFactory access_info_factory(broker(), dependencies(),
                                         graph()->zone());
-  if (!broker()->is_concurrent_inlining()) {
-    access_info_factory.ComputePropertyAccessInfos(
-        resolution_maps, factory()->then_string(), AccessMode::kLoad,
-        &access_infos);
-  } else {
-    // Obtain pre-computed access infos from the broker.
-    for (auto map : resolution_maps) {
-      MapRef map_ref = MakeRef(broker(), map);
-      access_infos.push_back(broker()->GetPropertyAccessInfo(
-          map_ref, MakeRef(broker(), isolate()->factory()->then_string()),
-          AccessMode::kLoad, dependencies()));
-    }
+
+  for (auto map : resolution_maps) {
+    access_infos.push_back(broker()->GetPropertyAccessInfo(
+        MakeRef(broker(), map),
+        MakeRef(broker(), isolate()->factory()->then_string()),
+        AccessMode::kLoad, dependencies(),
+        broker()->is_concurrent_inlining()
+            ? SerializationPolicy::kAssumeSerialized
+            : SerializationPolicy::kSerializeIfNeeded));
   }
   PropertyAccessInfo access_info =
       access_info_factory.FinalizePropertyAccessInfosAsOne(access_infos,