Commit 827e7bc4 authored by Sigurd Schneider's avatar Sigurd Schneider Committed by Commit Bot

Revert "[cpu-profiler] Turn on detailed line info for optimized code"

This reverts commit 898f880a.

Reason for revert: TSAN report memory leaks 
This is not related to this CL, but to behavior in tracing-controller.cc. Sorry!

https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8938962708686133568/+/steps/Check_-_slow_path__flakes_/0/logs/memory_grow/0

Original change's description:
> [cpu-profiler] Turn on detailed line info for optimized code
> 
> Cautiously turn on this flag by default to check the impact on
> performance bots. Could show minor regressions in old space and/or
> code_and_metadata memory buckets.
> 
> Bug: v8:7983
> Change-Id: Ic4369cdb0231f4f88eada699da948e8bb48a25fd
> Reviewed-on: https://chromium-review.googlesource.com/1162234
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#54908}

TBR=yangguo@chromium.org,petermarshall@chromium.org

Change-Id: If17abee873cb589fc6450231149ccc82e7ca9f7b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7983
Reviewed-on: https://chromium-review.googlesource.com/1163441Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54910}
parent a56d7470
......@@ -1253,8 +1253,9 @@ DEFINE_BOOL(log_function_events, false,
DEFINE_BOOL(prof, false,
"Log statistical profiling information (implies --log-code).")
DEFINE_BOOL(detailed_line_info, true,
DEFINE_BOOL(detailed_line_info, false,
"Always generate detailed line information for CPU profiling.")
DEFINE_IMPLICATION(future, detailed_line_info)
#if defined(ANDROID)
// Phones and tablets have processors that are much slower than desktop
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment