Commit 81a64aa5 authored by yangguo's avatar yangguo Committed by Commit bot

[debug] remove JSON debug protocol related tests.

In most cases we can use the debug event listener as alternative.
Multithreaded tests are obsolete.

R=jgruber@chromium.org
BUG=v8:5510

Review-Url: https://codereview.chromium.org/2529883002
Cr-Commit-Position: refs/heads/master@{#41256}
parent 21b0dbed
...@@ -170,30 +170,33 @@ class V8_EXPORT Debug { ...@@ -170,30 +170,33 @@ class V8_EXPORT Debug {
static bool CheckDebugBreak(Isolate* isolate); static bool CheckDebugBreak(Isolate* isolate);
// Message based interface. The message protocol is JSON. // Message based interface. The message protocol is JSON.
static void SetMessageHandler(Isolate* isolate, MessageHandler handler); V8_DEPRECATED("No longer supported",
static void SetMessageHandler(Isolate* isolate,
static void SendCommand(Isolate* isolate, MessageHandler handler));
const uint16_t* command, int length,
ClientData* client_data = NULL); V8_DEPRECATED("No longer supported",
static void SendCommand(Isolate* isolate,
/** const uint16_t* command, int length,
* Run a JavaScript function in the debugger. ClientData* client_data = NULL));
* \param fun the function to call
* \param data passed as second argument to the function /**
* With this call the debugger is entered and the function specified is called * Run a JavaScript function in the debugger.
* with the execution state as the first argument. This makes it possible to * \param fun the function to call
* get access to information otherwise not available during normal JavaScript * \param data passed as second argument to the function
* execution e.g. details on stack frames. Receiver of the function call will * With this call the debugger is entered and the function specified is called
* be the debugger context global object, however this is a subject to change. * with the execution state as the first argument. This makes it possible to
* The following example shows a JavaScript function which when passed to * get access to information otherwise not available during normal JavaScript
* v8::Debug::Call will return the current line of JavaScript execution. * execution e.g. details on stack frames. Receiver of the function call will
* * be the debugger context global object, however this is a subject to change.
* \code * The following example shows a JavaScript function which when passed to
* function frame_source_line(exec_state) { * v8::Debug::Call will return the current line of JavaScript execution.
* return exec_state.frame(0).sourceLine(); *
* } * \code
* \endcode * function frame_source_line(exec_state) {
*/ * return exec_state.frame(0).sourceLine();
* }
* \endcode
*/
// TODO(dcarney): data arg should be a MaybeLocal // TODO(dcarney): data arg should be a MaybeLocal
static MaybeLocal<Value> Call(Local<Context> context, static MaybeLocal<Value> Call(Local<Context> context,
v8::Local<v8::Function> fun, v8::Local<v8::Function> fun,
...@@ -236,7 +239,8 @@ class V8_EXPORT Debug { ...@@ -236,7 +239,8 @@ class V8_EXPORT Debug {
* "Evaluate" debug command behavior currently is not specified in scope * "Evaluate" debug command behavior currently is not specified in scope
* of this method. * of this method.
*/ */
static void ProcessDebugMessages(Isolate* isolate); V8_DEPRECATED("No longer supported",
static void ProcessDebugMessages(Isolate* isolate));
/** /**
* Debugger is running in its own context which is entered while debugger * Debugger is running in its own context which is entered while debugger
......
...@@ -77,9 +77,6 @@ ...@@ -77,9 +77,6 @@
'test-cpu-profiler/HotDeoptNoFrameEntry': [SKIP], 'test-cpu-profiler/HotDeoptNoFrameEntry': [SKIP],
'test-cpu-profiler/SampleWhenFrameIsNotSetup': [SKIP], 'test-cpu-profiler/SampleWhenFrameIsNotSetup': [SKIP],
# BUG(v8:4358). Hangs flakily.
'test-debug/ProcessDebugMessagesThreaded': [SKIP],
# BUG(2340). Preprocessing stack traces is disabled at the moment. # BUG(2340). Preprocessing stack traces is disabled at the moment.
'test-heap/PreprocessStackTrace': [FAIL], 'test-heap/PreprocessStackTrace': [FAIL],
......
This diff is collapsed.
Tests that Runtime.evaluate works with an empty stack
{
id : <messageId>
result : {
result : {
type : string
value : snape kills dumbledore
}
}
}
// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
print("Tests that Runtime.evaluate works with an empty stack");
InspectorTest.addScript("var text = [48116210, 34460128, 1406661984071834]");
var message = { expression: "text.map(x => x.toString(36)).join(' ')" };
Protocol.Runtime.evaluate(message)
.then(message => InspectorTest.logMessage(message))
.then(() => InspectorTest.completeTest());
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment