Commit 812a16da authored by Nico Hartmann's avatar Nico Hartmann Committed by Commit Bot

Revert "[debugger] Try to trigger pause-on-oom flakes with an extra printf"

This reverts commit 8f7e9158.

Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20node.js%20integration%20ng/10707?

Original change's description:
> [debugger] Try to trigger pause-on-oom flakes with an extra printf
>
> We have an issue that we can't repro locally. Enable back the
> pause-on-oom tests with an extra printf with DEBUG. We will be able to
> better assess the failures when they appear on the bot.
>
> Bug: v8:10876
> Change-Id: I066539c4b5865ecb6f2e589e9543e8c9ebd4830b
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474782
> Reviewed-by: Peter Marshall <petermarshall@chromium.org>
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#70558}

TBR=rmcilroy@chromium.org,petermarshall@chromium.org,solanes@chromium.org

Change-Id: I1b8a146d9496e889957636456b383f8d496658dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:10876
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2479004Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70559}
parent 8f7e9158
......@@ -502,10 +502,6 @@ size_t HeapLimitForDebugging(size_t initial_heap_limit) {
size_t V8Debugger::nearHeapLimitCallback(void* data, size_t current_heap_limit,
size_t initial_heap_limit) {
V8Debugger* thisPtr = static_cast<V8Debugger*>(data);
// TODO(solanes, v8:10876): Remove when bug is solved.
#if DEBUG
printf("nearHeapLimitCallback\n");
#endif
thisPtr->m_originalHeapLimit = current_heap_limit;
thisPtr->m_scheduledOOMBreak = true;
v8::Local<v8::Context> context =
......
Check pause on OOM
nearHeapLimitCallback
reason: OOM
Check pause on OOM
nearHeapLimitCallback
reason: OOM
......@@ -22,12 +22,11 @@
}], # ALWAYS
##############################################################################
['mode != debug', {
# Investigating flaky tests: https://crbug.com/v8/10876. Enable only on debug.
'debugger/pause-on-oom': [SKIP],
'debugger/pause-on-oom-wide': [SKIP],
'debugger/pause-on-oom-extrawide': [SKIP],
}], # 'mode != debug'
['arch == x64 and mode == debug', {
# Flaky tests: https://crbug.com/v8/10876
'debugger/pause-on-oom-extrawide': [PASS, FAIL],
'debugger/pause-on-oom-wide': [PASS, FAIL],
}], # 'arch == x64 and mode == debug'
##############################################################################
['system == android', {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment