Commit 811d73aa authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[wasm][messages] Remove handling for interpreted frames

The interpreter frame is only used for testing now (see linked issue).
This CL removes some remnants in messages.{h,cc}.

R=bmeurer@chromium.org

Bug: v8:10389
Change-Id: I369057ed02dbb68ba40ef9b4aa9a84799d3db528
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2681944
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Clemens Backes <clemensb@chromium.org>
Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72581}
parent 6fa31e17
...@@ -639,10 +639,7 @@ Handle<Script> JSStackFrame::GetScript() const { ...@@ -639,10 +639,7 @@ Handle<Script> JSStackFrame::GetScript() const {
void WasmStackFrame::FromFrameArray(Isolate* isolate, Handle<FrameArray> array, void WasmStackFrame::FromFrameArray(Isolate* isolate, Handle<FrameArray> array,
int frame_ix) { int frame_ix) {
// This function is called for compiled and interpreted wasm frames, and for DCHECK(array->IsWasmFrame(frame_ix) || array->IsAsmJsWasmFrame(frame_ix));
// asm.js->wasm frames.
DCHECK(array->IsWasmFrame(frame_ix) ||
array->IsAsmJsWasmFrame(frame_ix));
isolate_ = isolate; isolate_ = isolate;
wasm_instance_ = handle(array->WasmInstance(frame_ix), isolate); wasm_instance_ = handle(array->WasmInstance(frame_ix), isolate);
wasm_func_index_ = array->WasmFunctionIndex(frame_ix).value(); wasm_func_index_ = array->WasmFunctionIndex(frame_ix).value();
...@@ -691,7 +688,7 @@ Handle<PrimitiveHeapObject> WasmStackFrame::GetWasmModuleName() { ...@@ -691,7 +688,7 @@ Handle<PrimitiveHeapObject> WasmStackFrame::GetWasmModuleName() {
Handle<HeapObject> WasmStackFrame::GetWasmInstance() { return wasm_instance_; } Handle<HeapObject> WasmStackFrame::GetWasmInstance() { return wasm_instance_; }
int WasmStackFrame::GetPosition() const { int WasmStackFrame::GetPosition() const {
return IsInterpreted() ? offset_ : code_->GetSourcePositionBefore(offset_); return code_->GetSourcePositionBefore(offset_);
} }
int WasmStackFrame::GetColumnNumber() { return GetModuleOffset(); } int WasmStackFrame::GetColumnNumber() { return GetModuleOffset(); }
......
...@@ -202,7 +202,6 @@ class WasmStackFrame : public StackFrameBase { ...@@ -202,7 +202,6 @@ class WasmStackFrame : public StackFrameBase {
bool IsPromiseAny() const override { return false; } bool IsPromiseAny() const override { return false; }
bool IsConstructor() override { return false; } bool IsConstructor() override { return false; }
bool IsStrict() const override { return false; } bool IsStrict() const override { return false; }
bool IsInterpreted() const { return code_ == nullptr; }
protected: protected:
Handle<PrimitiveHeapObject> Null() const; Handle<PrimitiveHeapObject> Null() const;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment