Skip to content

V
V8
Commit 80efc9d2 authored by titzer's avatar titzer Committed by Commit bot
Browse files
Options

Fix presubmit errors in runtime-simd.cc. 

R=mstarzinger@chromium.org
BUG=
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1263363002

Cr-Commit-Position: refs/heads/master@{#29977}
parent 0924d6d5
Show whitespace changes
Inline Side-by-side
Showing with 16 additions and 12 deletions
src/runtime/runtime-simd.cc
View file @ 80efc9d2
...@@ -19,10 +19,11 @@ ...@@ -19,10 +19,11 @@
#define SIMD_CREATE_NUMERIC_FUNCTION(type, lane_type, lane_count) \ #define SIMD_CREATE_NUMERIC_FUNCTION(type, lane_type, lane_count) \
RUNTIME_FUNCTION(Runtime_Create##type) { \ RUNTIME_FUNCTION(Runtime_Create##type) { \
static const int kLaneCount = lane_count; \
HandleScope scope(isolate); \ HandleScope scope(isolate); \
DCHECK(args.length() == lane_count); \ DCHECK(args.length() == kLaneCount); \
lane_type lanes[lane_count]; \ lane_type lanes[kLaneCount]; \
for (int i = 0; i < lane_count; i++) { \ for (int i = 0; i < kLaneCount; i++) { \
CONVERT_NUMBER_ARG_HANDLE_CHECKED(number, i); \ CONVERT_NUMBER_ARG_HANDLE_CHECKED(number, i); \
lanes[i] = ConvertNumber<lane_type>(number->Number()); \ lanes[i] = ConvertNumber<lane_type>(number->Number()); \
} \ } \
...@@ -31,10 +32,11 @@ ...@@ -31,10 +32,11 @@
#define SIMD_CREATE_BOOLEAN_FUNCTION(type, lane_count) \ #define SIMD_CREATE_BOOLEAN_FUNCTION(type, lane_count) \
RUNTIME_FUNCTION(Runtime_Create##type) { \ RUNTIME_FUNCTION(Runtime_Create##type) { \
static const int kLaneCount = lane_count; \
HandleScope scope(isolate); \ HandleScope scope(isolate); \
DCHECK(args.length() == lane_count); \ DCHECK(args.length() == kLaneCount); \
bool lanes[lane_count]; \ bool lanes[kLaneCount]; \
for (int i = 0; i < lane_count; i++) { \ for (int i = 0; i < kLaneCount; i++) { \
lanes[i] = args[i]->BooleanValue(); \ lanes[i] = args[i]->BooleanValue(); \
} \ } \
return *isolate->factory()->New##type(lanes); \ return *isolate->factory()->New##type(lanes); \
...@@ -58,13 +60,14 @@ ...@@ -58,13 +60,14 @@
#define SIMD_REPLACE_NUMERIC_LANE_FUNCTION(type, lane_type, lane_count) \ #define SIMD_REPLACE_NUMERIC_LANE_FUNCTION(type, lane_type, lane_count) \
RUNTIME_FUNCTION(Runtime_##type##ReplaceLane) { \ RUNTIME_FUNCTION(Runtime_##type##ReplaceLane) { \
static const int kLaneCount = lane_count; \
HandleScope scope(isolate); \ HandleScope scope(isolate); \
DCHECK(args.length() == 3); \ DCHECK(args.length() == 3); \
CONVERT_ARG_HANDLE_CHECKED(type, simd, 0); \ CONVERT_ARG_HANDLE_CHECKED(type, simd, 0); \
CONVERT_SIMD_LANE_ARG_CHECKED(lane, 1, lane_count); \ CONVERT_SIMD_LANE_ARG_CHECKED(lane, 1, kLaneCount); \
CONVERT_NUMBER_ARG_HANDLE_CHECKED(number, 2); \ CONVERT_NUMBER_ARG_HANDLE_CHECKED(number, 2); \
lane_type lanes[lane_count]; \ lane_type lanes[kLaneCount]; \
for (int i = 0; i < lane_count; i++) { \ for (int i = 0; i < kLaneCount; i++) { \
lanes[i] = simd->get_lane(i); \ lanes[i] = simd->get_lane(i); \
} \ } \
lanes[lane] = ConvertNumber<lane_type>(number->Number()); \ lanes[lane] = ConvertNumber<lane_type>(number->Number()); \
...@@ -74,12 +77,13 @@ ...@@ -74,12 +77,13 @@
#define SIMD_REPLACE_BOOLEAN_LANE_FUNCTION(type, lane_count) \ #define SIMD_REPLACE_BOOLEAN_LANE_FUNCTION(type, lane_count) \
RUNTIME_FUNCTION(Runtime_##type##ReplaceLane) { \ RUNTIME_FUNCTION(Runtime_##type##ReplaceLane) { \
static const int kLaneCount = lane_count; \
HandleScope scope(isolate); \ HandleScope scope(isolate); \
DCHECK(args.length() == 3); \ DCHECK(args.length() == 3); \
CONVERT_ARG_HANDLE_CHECKED(type, simd, 0); \ CONVERT_ARG_HANDLE_CHECKED(type, simd, 0); \
CONVERT_SIMD_LANE_ARG_CHECKED(lane, 1, lane_count); \ CONVERT_SIMD_LANE_ARG_CHECKED(lane, 1, kLaneCount); \
bool lanes[lane_count]; \ bool lanes[kLaneCount]; \
for (int i = 0; i < lane_count; i++) { \ for (int i = 0; i < kLaneCount; i++) { \
lanes[i] = simd->get_lane(i); \ lanes[i] = simd->get_lane(i); \
} \ } \
lanes[lane] = args[2]->BooleanValue(); \ lanes[lane] = args[2]->BooleanValue(); \
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment