Commit 80d11fce authored by Philip Pfaffe's avatar Philip Pfaffe Committed by V8 LUCI CQ

[ic] Remove the IsDebugActive condition for side-effect-free evaluate

Side-Effect-free debug evaluate is available through the CDP Runtime
domain as well, besides the Debugger domain, and does not require
debugging to be active.

Change-Id: I84af194af65cbac311d208e35af7338cb675eb36
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2902729
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74631}
parent e54c81a4
...@@ -14044,9 +14044,6 @@ TNode<BoolT> CodeStubAssembler::IsSideEffectFreeDebuggingActive() { ...@@ -14044,9 +14044,6 @@ TNode<BoolT> CodeStubAssembler::IsSideEffectFreeDebuggingActive() {
TNode<BoolT> is_active = TNode<BoolT> is_active =
Word32Equal(debug_execution_mode, Word32Equal(debug_execution_mode,
Int32Constant(DebugInfo::ExecutionMode::kSideEffects)); Int32Constant(DebugInfo::ExecutionMode::kSideEffects));
#ifdef DEBUG
CSA_ASSERT(this, Word32Or(IsDebugActive(), Word32BinaryNot(is_active)));
#endif
return is_active; return is_active;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment