[wasm] Remove negation in --wasm-no-[bounds-checks|stack-checks]

The flag naming was confusing, and inconsistent with other flags. To
disable bounds checks, you now have to say --no-wasm-bounds-checks
instead of the original --wasm-no-bounds-checks. Similarly, it is now
--no-wasm-stack-checks instead of --wasm-no-stack-checks.

R=clemensb@chromium.org

Bug: v8:10021
Change-Id: Ib57963866af794d4e47d68e520a42b4054ed2a8f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2017475
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66003}

src/compiler/wasm-compiler.cc

@@ -317,7 +317,7 @@ Node* WasmGraphBuilder::IntPtrConstant(intptr_t value) {
 
 void WasmGraphBuilder::StackCheck(wasm::WasmCodePosition position) {
   DCHECK_NOT_NULL(env_);  // Wrappers don't get stack checks.
-  if (FLAG_wasm_no_stack_checks || !env_->runtime_exception_support) {
+  if (!FLAG_wasm_stack_checks || !env_->runtime_exception_support) {
     return;
   }
 
@@ -3557,7 +3557,7 @@ Node* WasmGraphBuilder::BoundsCheckMem(uint8_t access_size, Node* index,
                                        EnforceBoundsCheck enforce_check) {
   DCHECK_LE(1, access_size);
   index = Uint32ToUintptr(index);
-  if (FLAG_wasm_no_bounds_checks) return index;
+  if (!FLAG_wasm_bounds_checks) return index;
 
   if (use_trap_handler() && enforce_check == kCanOmitBoundsCheck) {
     return index;

src/flags/flag-definitions.h

@@ -742,10 +742,11 @@ FOREACH_WASM_STAGING_FEATURE_FLAG(WASM_STAGING_IMPLICATION)
 #undef WASM_STAGING_IMPLICATION
 
 DEFINE_BOOL(wasm_opt, false, "enable wasm optimization")
-DEFINE_BOOL(wasm_no_bounds_checks, false,
-            "disable bounds checks (performance testing only)")
-DEFINE_BOOL(wasm_no_stack_checks, false,
-            "disable stack checks (performance testing only)")
+DEFINE_BOOL(
+    wasm_bounds_checks, true,
+    "enable bounds checks (disable for performance testing only)")
+DEFINE_BOOL(wasm_stack_checks, true,
+            "enable stack checks (disable for performance testing only)")
 DEFINE_BOOL(wasm_math_intrinsics, true,
             "intrinsify some Math imports into wasm")
 

src/wasm/baseline/liftoff-compiler.cc

@@ -471,7 +471,7 @@ class LiftoffCompiler {
   }
 
   void StackCheck(WasmCodePosition position) {
-    if (FLAG_wasm_no_stack_checks || !env_->runtime_exception_support) return;
+    if (!FLAG_wasm_stack_checks || !env_->runtime_exception_support) return;
     out_of_line_code_.push_back(
         OutOfLineCode::StackCheck(position, __ cache_state()->used_registers,
                                   RegisterDebugSideTableEntry()));
@@ -1703,7 +1703,7 @@ class LiftoffCompiler {
 
   Label* AddOutOfLineTrap(WasmCodePosition position,
                           WasmCode::RuntimeStubId stub, uint32_t pc = 0) {
-    DCHECK(!FLAG_wasm_no_bounds_checks);
+    DCHECK(FLAG_wasm_bounds_checks);
     // The pc is needed for memory OOB trap with trap handler enabled. Other
     // callers should not even compute it.
     DCHECK_EQ(pc != 0, stub == WasmCode::kThrowWasmTrapMemOutOfBounds &&
@@ -1725,7 +1725,7 @@ class LiftoffCompiler {
         !base::IsInBounds(offset, access_size, env_->max_memory_size);
 
     if (!force_check && !statically_oob &&
-        (FLAG_wasm_no_bounds_checks || env_->use_trap_handler)) {
+        (!FLAG_wasm_bounds_checks || env_->use_trap_handler)) {
       return false;
     }