Commit 8053d89a authored by Jakob Gruber's avatar Jakob Gruber Committed by Commit Bot

[nci] Extract feedback collection experiment to dedicated flag

This adds a dedicated --turbo-collect-feedback-in-generic-lowering
flag instead of piggy-backing on top of --turbo-nci in order to free
that up for upcoming work.

The new flag is temporary and can be removed once we've collected
enough data and made a decision on whether to enable it
unconditionally.

Bug: v8:8888
Change-Id: I5c0fd35e46b4c0237c266ba6253b9c5cb4cd7995
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237137
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68287}
parent c036b6cd
...@@ -20,7 +20,9 @@ namespace compiler { ...@@ -20,7 +20,9 @@ namespace compiler {
// //
// TODO(jgruber): Remove once we've made a decision whether to collect feedback // TODO(jgruber): Remove once we've made a decision whether to collect feedback
// unconditionally. // unconditionally.
inline bool CollectFeedbackInGenericLowering() { return FLAG_turbo_nci; } inline bool CollectFeedbackInGenericLowering() {
return FLAG_turbo_collect_feedback_in_generic_lowering;
}
enum class StackCheckKind { enum class StackCheckKind {
kJSFunctionEntry = 0, kJSFunctionEntry = 0,
......
...@@ -663,6 +663,8 @@ DEFINE_BOOL(turbo_nci_as_highest_tier, false, ...@@ -663,6 +663,8 @@ DEFINE_BOOL(turbo_nci_as_highest_tier, false,
"purposes.") "purposes.")
DEFINE_BOOL(print_nci_code, false, "print native context independent code.") DEFINE_BOOL(print_nci_code, false, "print native context independent code.")
DEFINE_BOOL(trace_turbo_nci, false, "trace native context independent code.") DEFINE_BOOL(trace_turbo_nci, false, "trace native context independent code.")
DEFINE_BOOL(turbo_collect_feedback_in_generic_lowering, false,
"enable experimental feedback collection in generic lowering.")
// Favor memory over execution speed. // Favor memory over execution speed.
DEFINE_BOOL(optimize_for_size, false, DEFINE_BOOL(optimize_for_size, false,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment