Skip to content

V
V8
Commit 801f1b6d authored by bmeurer's avatar bmeurer Committed by Commit bot
Browse files
Options

[assembler] Remove obsolete InvokeBuiltin macro. 

We no longer have the concept of "JS builtins" exposed to handwritten
native code, so there's no need to keep the InvokeBuiltin macro around.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/1611613002

Cr-Commit-Position: refs/heads/master@{#33416}
parent 8e8bd866
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 129 deletions
src/arm/macro-assembler-arm.cc
View file @ 801f1b6d
......@@ -2506,18 +2506,6 @@ void MacroAssembler::JumpToExternalReference(const ExternalReference& builtin) {
}
void MacroAssembler::InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper) {
// You can't call a builtin without a valid frame.
DCHECK(flag == JUMP_FUNCTION || has_frame());
// Fake a parameter count to avoid emitting code to do the check.
ParameterCount expected(0);
LoadNativeContextSlot(native_context_index, r1);
InvokeFunctionCode(r1, no_reg, expected, expected, flag, call_wrapper);
}
void MacroAssembler::SetCounter(StatsCounter* counter, int value,
Register scratch1, Register scratch2) {
if (FLAG_native_code_counters && counter->Enabled()) {
......
src/arm/macro-assembler-arm.h
View file @ 801f1b6d
......@@ -1144,10 +1144,6 @@ class MacroAssembler: public Assembler {
// Jump to a runtime routine.
void JumpToExternalReference(const ExternalReference& builtin);
// Invoke specified builtin JavaScript function.
void InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper = NullCallWrapper());
Handle<Object> CodeObject() {
DCHECK(!code_object_.is_null());
return code_object_;
......
src/arm64/macro-assembler-arm64.cc
View file @ 801f1b6d
......@@ -1727,19 +1727,6 @@ void MacroAssembler::JumpToExternalReference(const ExternalReference& builtin) {
}
void MacroAssembler::InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper) {
ASM_LOCATION("MacroAssembler::InvokeBuiltin");
// You can't call a builtin without a valid frame.
DCHECK(flag == JUMP_FUNCTION || has_frame());
// Fake a parameter count to avoid emitting code to do the check.
ParameterCount expected(0);
LoadNativeContextSlot(native_context_index, x1);
InvokeFunctionCode(x1, no_reg, expected, expected, flag, call_wrapper);
}
void MacroAssembler::TailCallRuntime(Runtime::FunctionId fid) {
const Runtime::Function* function = Runtime::FunctionForId(fid);
DCHECK_EQ(1, function->result_size);
......
src/arm64/macro-assembler-arm64.h
View file @ 801f1b6d
......@@ -1139,10 +1139,6 @@ class MacroAssembler : public Assembler {
int num_arguments);
// Invoke specified builtin JavaScript function.
void InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper = NullCallWrapper());
void Jump(Register target);
void Jump(Address target, RelocInfo::Mode rmode, Condition cond = al);
void Jump(Handle<Code> code, RelocInfo::Mode rmode, Condition cond = al);
......
src/ia32/macro-assembler-ia32.cc
View file @ 801f1b6d
......@@ -2147,18 +2147,6 @@ void MacroAssembler::InvokeFunction(Handle<JSFunction> function,
}
void MacroAssembler::InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper) {
// You can't call a builtin without a valid frame.
DCHECK(flag == JUMP_FUNCTION || has_frame());
// Fake a parameter count to avoid emitting code to do the check.
ParameterCount expected(0);
GetBuiltinFunction(edi, native_context_index);
InvokeFunctionCode(edi, no_reg, expected, expected, flag, call_wrapper);
}
void MacroAssembler::GetBuiltinFunction(Register target,
int native_context_index) {
// Load the JavaScript builtin function from the builtins object.
......
src/ia32/macro-assembler-ia32.h
View file @ 801f1b6d
......@@ -331,10 +331,6 @@ class MacroAssembler: public Assembler {
const ParameterCount& actual, InvokeFlag flag,
const CallWrapper& call_wrapper);
// Invoke specified builtin JavaScript function.
void InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper = NullCallWrapper());
// Store the function for the given builtin in the target register.
void GetBuiltinFunction(Register target, int native_context_index);
......
src/mips/macro-assembler-mips.cc
View file @ 801f1b6d
......@@ -4571,18 +4571,6 @@ void MacroAssembler::JumpToExternalReference(const ExternalReference& builtin,
}
void MacroAssembler::InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper) {
// You can't call a builtin without a valid frame.
DCHECK(flag == JUMP_FUNCTION || has_frame());
// Fake a parameter count to avoid emitting code to do the check.
ParameterCount expected(0);
LoadNativeContextSlot(native_context_index, a1);
InvokeFunctionCode(a1, no_reg, expected, expected, flag, call_wrapper);
}
void MacroAssembler::SetCounter(StatsCounter* counter, int value,
Register scratch1, Register scratch2) {
if (FLAG_native_code_counters && counter->Enabled()) {
......
src/mips/macro-assembler-mips.h
View file @ 801f1b6d
......@@ -1328,10 +1328,6 @@ const Operand& rt = Operand(zero_reg), BranchDelaySlot bd = PROTECT
void JumpToExternalReference(const ExternalReference& builtin,
BranchDelaySlot bd = PROTECT);
// Invoke specified builtin JavaScript function.
void InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper = NullCallWrapper());
struct Unresolved {
int pc;
uint32_t flags; // See Bootstrapper::FixupFlags decoders/encoders.
......
src/mips64/macro-assembler-mips64.cc
View file @ 801f1b6d
......@@ -5230,18 +5230,6 @@ void MacroAssembler::JumpToExternalReference(const ExternalReference& builtin,
}
void MacroAssembler::InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper) {
// You can't call a builtin without a valid frame.
DCHECK(flag == JUMP_FUNCTION || has_frame());
// Fake a parameter count to avoid emitting code to do the check.
ParameterCount expected(0);
LoadNativeContextSlot(native_context_index, a1);
InvokeFunctionCode(a1, no_reg, expected, expected, flag, call_wrapper);
}
void MacroAssembler::SetCounter(StatsCounter* counter, int value,
Register scratch1, Register scratch2) {
if (FLAG_native_code_counters && counter->Enabled()) {
......
src/mips64/macro-assembler-mips64.h
View file @ 801f1b6d
......@@ -1450,10 +1450,6 @@ const Operand& rt = Operand(zero_reg), BranchDelaySlot bd = PROTECT
void JumpToExternalReference(const ExternalReference& builtin,
BranchDelaySlot bd = PROTECT);
// Invoke specified builtin JavaScript function.
void InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper = NullCallWrapper());
struct Unresolved {
int pc;
uint32_t flags; // See Bootstrapper::FixupFlags decoders/encoders.
......
src/ppc/macro-assembler-ppc.cc
View file @ 801f1b6d
......@@ -2335,18 +2335,6 @@ void MacroAssembler::JumpToExternalReference(const ExternalReference& builtin) {
}
void MacroAssembler::InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper) {
// You can't call a builtin without a valid frame.
DCHECK(flag == JUMP_FUNCTION || has_frame());
// Fake a parameter count to avoid emitting code to do the check.
ParameterCount expected(0);
LoadNativeContextSlot(native_context_index, r4);
InvokeFunctionCode(r4, no_reg, expected, expected, flag, call_wrapper);
}
void MacroAssembler::SetCounter(StatsCounter* counter, int value,
Register scratch1, Register scratch2) {
if (FLAG_native_code_counters && counter->Enabled()) {
......
src/ppc/macro-assembler-ppc.h
View file @ 801f1b6d
......@@ -1005,10 +1005,6 @@ class MacroAssembler : public Assembler {
// Jump to a runtime routine.
void JumpToExternalReference(const ExternalReference& builtin);
// Invoke specified builtin JavaScript function.
void InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper = NullCallWrapper());
Handle<Object> CodeObject() {
DCHECK(!code_object_.is_null());
return code_object_;
......
src/x64/macro-assembler-x64.cc
View file @ 801f1b6d
......@@ -690,18 +690,6 @@ void MacroAssembler::JumpToExternalReference(const ExternalReference& ext) {
}
void MacroAssembler::InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper) {
// You can't call a builtin without a valid frame.
DCHECK(flag == JUMP_FUNCTION || has_frame());
// Fake a parameter count to avoid emitting code to do the check.
ParameterCount expected(0);
LoadNativeContextSlot(native_context_index, rdi);
InvokeFunctionCode(rdi, no_reg, expected, expected, flag, call_wrapper);
}
#define REG(Name) \
{ Register::kCode_##Name }
......
src/x64/macro-assembler-x64.h
View file @ 801f1b6d
......@@ -396,10 +396,6 @@ class MacroAssembler: public Assembler {
InvokeFlag flag,
const CallWrapper& call_wrapper);
// Invoke specified builtin JavaScript function.
void InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper = NullCallWrapper());
// ---------------------------------------------------------------------------
// Smi tagging, untagging and operations on tagged smis.
......
src/x87/macro-assembler-x87.cc
View file @ 801f1b6d
......@@ -2111,18 +2111,6 @@ void MacroAssembler::InvokeFunction(Handle<JSFunction> function,
}
void MacroAssembler::InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper) {
// You can't call a builtin without a valid frame.
DCHECK(flag == JUMP_FUNCTION || has_frame());
// Fake a parameter count to avoid emitting code to do the check.
ParameterCount expected(0);
GetBuiltinFunction(edi, native_context_index);
InvokeFunctionCode(edi, no_reg, expected, expected, flag, call_wrapper);
}
void MacroAssembler::GetBuiltinFunction(Register target,
int native_context_index) {
// Load the JavaScript builtin function from the builtins object.
......
src/x87/macro-assembler-x87.h
View file @ 801f1b6d
......@@ -326,10 +326,6 @@ class MacroAssembler: public Assembler {
const ParameterCount& actual, InvokeFlag flag,
const CallWrapper& call_wrapper);
// Invoke specified builtin JavaScript function.
void InvokeBuiltin(int native_context_index, InvokeFlag flag,
const CallWrapper& call_wrapper = NullCallWrapper());
// Store the function for the given builtin in the target register.
void GetBuiltinFunction(Register target, int native_context_index);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment