Commit 7eb91175 authored by Michael Starzinger's avatar Michael Starzinger Committed by Commit Bot

[flags] Remove deprecated Hydrogen specific flags.

R=tebbi@chromium.org

Change-Id: I9d22e0731da3e170fe40aa34667ff8948e11bb5c
Reviewed-on: https://chromium-review.googlesource.com/595972Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47124}
parent 4711e6d6
...@@ -3145,7 +3145,6 @@ int Shell::Main(int argc, char* argv[]) { ...@@ -3145,7 +3145,6 @@ int Shell::Main(int argc, char* argv[]) {
} else { } else {
v8::V8::InitializeExternalStartupData(argv[0]); v8::V8::InitializeExternalStartupData(argv[0]);
} }
SetFlagsFromString("--trace-hydrogen-file=hydrogen.cfg");
SetFlagsFromString("--trace-turbo-cfg-file=turbo.cfg"); SetFlagsFromString("--trace-turbo-cfg-file=turbo.cfg");
SetFlagsFromString("--redirect-code-traces-to=code.asm"); SetFlagsFromString("--redirect-code-traces-to=code.asm");
int result = 0; int result = 0;
......
...@@ -339,7 +339,6 @@ DEFINE_STRING(trace_ignition_dispatches_output_file, nullptr, ...@@ -339,7 +339,6 @@ DEFINE_STRING(trace_ignition_dispatches_output_file, nullptr,
"written (by default, the table is not written to a file)") "written (by default, the table is not written to a file)")
// Flags for Crankshaft. // Flags for Crankshaft.
DEFINE_STRING(hydrogen_filter, "*", "optimization filter")
DEFINE_BOOL(use_allocation_folding, true, "use allocation folding") DEFINE_BOOL(use_allocation_folding, true, "use allocation folding")
DEFINE_BOOL(use_local_allocation_folding, false, "only fold in basic blocks") DEFINE_BOOL(use_local_allocation_folding, false, "only fold in basic blocks")
DEFINE_BOOL(use_write_barrier_elimination, true, DEFINE_BOOL(use_write_barrier_elimination, true,
...@@ -358,11 +357,6 @@ DEFINE_FLOAT(min_inlining_frequency, 0.15, "minimum frequency for inlining") ...@@ -358,11 +357,6 @@ DEFINE_FLOAT(min_inlining_frequency, 0.15, "minimum frequency for inlining")
DEFINE_BOOL(fast_math, true, "faster (but maybe less accurate) math functions") DEFINE_BOOL(fast_math, true, "faster (but maybe less accurate) math functions")
DEFINE_BOOL(trace_environment_liveness, false, DEFINE_BOOL(trace_environment_liveness, false,
"trace liveness of local variable slots") "trace liveness of local variable slots")
DEFINE_BOOL(trace_hydrogen, false, "trace generated hydrogen to file")
DEFINE_STRING(trace_hydrogen_filter, "*", "hydrogen tracing filter")
DEFINE_BOOL(trace_hydrogen_stubs, false, "trace generated hydrogen for stubs")
DEFINE_STRING(trace_hydrogen_file, NULL, "trace hydrogen to given file name")
DEFINE_STRING(trace_phase, "HLZ", "trace generated IR for specified phases")
DEFINE_BOOL(trace_store_elimination, false, "trace store elimination") DEFINE_BOOL(trace_store_elimination, false, "trace store elimination")
DEFINE_BOOL(turbo_verify_store_elimination, false, DEFINE_BOOL(turbo_verify_store_elimination, false,
"verify store elimination more rigorously") "verify store elimination more rigorously")
......
...@@ -2790,8 +2790,7 @@ bool Isolate::Init(StartupDeserializer* des) { ...@@ -2790,8 +2790,7 @@ bool Isolate::Init(StartupDeserializer* des) {
set_event_logger(Logger::DefaultEventLoggerSentinel); set_event_logger(Logger::DefaultEventLoggerSentinel);
} }
if (FLAG_trace_hydrogen || FLAG_trace_hydrogen_stubs || FLAG_trace_turbo || if (FLAG_trace_turbo || FLAG_trace_turbo_graph) {
FLAG_trace_turbo_graph) {
PrintF("Concurrent recompilation has been disabled for tracing.\n"); PrintF("Concurrent recompilation has been disabled for tracing.\n");
} else if (OptimizingCompileDispatcher::Enabled()) { } else if (OptimizingCompileDispatcher::Enabled()) {
optimizing_compile_dispatcher_ = new OptimizingCompileDispatcher(this); optimizing_compile_dispatcher_ = new OptimizingCompileDispatcher(this);
......
...@@ -253,7 +253,7 @@ class SharedFunctionInfo : public HeapObject { ...@@ -253,7 +253,7 @@ class SharedFunctionInfo : public HeapObject {
// The function cannot cause any side effects. // The function cannot cause any side effects.
bool HasNoSideEffect(); bool HasNoSideEffect();
// Used for flags such as --hydrogen-filter. // Used for flags such as --turbo-filter.
bool PassesFilter(const char* raw_filter); bool PassesFilter(const char* raw_filter);
// Position of the 'function' token in the script source. // Position of the 'function' token in the script source.
......
...@@ -135,8 +135,7 @@ static void GetICCounts(JSFunction* function, int* ic_with_type_info_count, ...@@ -135,8 +135,7 @@ static void GetICCounts(JSFunction* function, int* ic_with_type_info_count,
static void TraceRecompile(JSFunction* function, const char* reason, static void TraceRecompile(JSFunction* function, const char* reason,
const char* type) { const char* type) {
if (FLAG_trace_opt && if (FLAG_trace_opt) {
function->shared()->PassesFilter(FLAG_hydrogen_filter)) {
PrintF("[marking "); PrintF("[marking ");
function->ShortPrint(); function->ShortPrint();
PrintF(" for %s recompilation, reason: %s", type, reason); PrintF(" for %s recompilation, reason: %s", type, reason);
......
...@@ -25,8 +25,6 @@ ...@@ -25,8 +25,6 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --hydrogen-filter=Debug.setBreakPoint
Debug = debug.Debug Debug = debug.Debug
Debug.setListener(function(){}); Debug.setListener(function(){});
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment