Commit 7e456fac authored by Patrick Thier's avatar Patrick Thier Committed by V8 LUCI CQ

[test] Don't expose d8.test.verifySourcePostions for correctness fuzzing

Different runs of the correctness fuzzer might flush the bytecode
of the function passed to d8.test.verifySourcePositions, resulting
in spurious errors. Therefore don't expose verifySourcePositions
for correctness fuzzing.

Bug: chromium:1209242
Change-Id: I0395afcd5a5e109779d7b79d9f6939899eaaf99c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2903144
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Auto-Submit: Patrick Thier <pthier@chromium.org>
Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74635}
parent 4db243f2
......@@ -2786,9 +2786,13 @@ Local<ObjectTemplate> Shell::CreateD8Template(Isolate* isolate) {
}
{
Local<ObjectTemplate> test_template = ObjectTemplate::New(isolate);
test_template->Set(
isolate, "verifySourcePositions",
FunctionTemplate::New(isolate, TestVerifySourcePositions));
// For different runs of correctness fuzzing the bytecode of a function
// might get flushed, resulting in spurious errors.
if (!i::FLAG_correctness_fuzzer_suppressions) {
test_template->Set(
isolate, "verifySourcePositions",
FunctionTemplate::New(isolate, TestVerifySourcePositions));
}
// Correctness fuzzing will attempt to compare results of tests with and
// without turbo_fast_api_calls, so we don't expose the fast_c_api
// constructor when --correctness_fuzzer_suppressions is on.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment