Commit 7e1867d6 authored by machenbach's avatar machenbach Committed by Commit bot

[gn] Set reasonable defaults for debugging

BUG=chromium:474921

Review-Url: https://codereview.chromium.org/2182933002
Cr-Commit-Position: refs/heads/master@{#38048}
parent 2fec36d9
...@@ -32,7 +32,7 @@ declare_args() { ...@@ -32,7 +32,7 @@ declare_args() {
v8_embed_script = "" v8_embed_script = ""
# Sets -dENABLE_DISASSEMBLER. # Sets -dENABLE_DISASSEMBLER.
v8_enable_disassembler = false v8_enable_disassembler = ""
# Sets -dENABLE_GDB_JIT_INTERFACE. # Sets -dENABLE_GDB_JIT_INTERFACE.
v8_enable_gdbjit = "" v8_enable_gdbjit = ""
...@@ -52,7 +52,7 @@ declare_args() { ...@@ -52,7 +52,7 @@ declare_args() {
v8_interpreted_regexp = false v8_interpreted_regexp = false
# Sets -dOBJECT_PRINT. # Sets -dOBJECT_PRINT.
v8_object_print = false v8_object_print = ""
# With post mortem support enabled, metadata is embedded into libv8 that # With post mortem support enabled, metadata is embedded into libv8 that
# describes various parameters of the VM for use by debuggers. See # describes various parameters of the VM for use by debuggers. See
...@@ -83,6 +83,14 @@ if (v8_enable_gdbjit == "") { ...@@ -83,6 +83,14 @@ if (v8_enable_gdbjit == "") {
} }
} }
# Derived defaults.
if (v8_object_print == "") {
v8_object_print = is_debug && !v8_optimized_debug
}
if (v8_enable_disassembler == "") {
v8_enable_disassembler = is_debug && !v8_optimized_debug
}
v8_generated_peephole_source = "$target_gen_dir/bytecode-peephole-table.cc" v8_generated_peephole_source = "$target_gen_dir/bytecode-peephole-table.cc"
v8_random_seed = "314159265" v8_random_seed = "314159265"
v8_toolset_for_shell = "host" v8_toolset_for_shell = "host"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment