Remove unused default argument value in ExpressionClassifier::Accumulate

Also removed the "StandardProductions" enum value as its name is unhelpful
in deciding when to use it (and it only had a single reference).

R=gsathya@chromium.org

Review-Url: https://codereview.chromium.org/2260183003
Cr-Commit-Position: refs/heads/master@{#38763}

src/parsing/expression-classifier.h

@@ -71,11 +71,10 @@ class ExpressionClassifier {
          LetPatternProduction | AsyncBindingPatternProduction),
     FormalParametersProductions = (DistinctFormalParametersProduction |
                                    StrictModeFormalParametersProduction),
-    StandardProductions = ExpressionProductions | PatternProductions,
     AllProductions =
-        (StandardProductions | FormalParametersProductions |
-         ArrowFormalParametersProduction | CoverInitializedNameProduction |
-         AsyncArrowFormalParametersProduction | AsyncBindingPatternProduction)
+        (ExpressionProductions | PatternProductions |
+         FormalParametersProductions | ArrowFormalParametersProduction |
+         CoverInitializedNameProduction | AsyncArrowFormalParametersProduction)
   };
 
   enum FunctionProperties : unsigned {
@@ -345,8 +344,7 @@ class ExpressionClassifier {
     invalid_productions_ &= ~AssignmentPatternProduction;
   }
 
-  void Accumulate(ExpressionClassifier* inner,
-                  unsigned productions = StandardProductions,
+  void Accumulate(ExpressionClassifier* inner, unsigned productions,
                   bool merge_non_patterns = true) {
     DCHECK_EQ(inner->reported_errors_, reported_errors_);
     DCHECK_EQ(inner->reported_errors_begin_, reported_errors_end_);

src/parsing/parser-base.h

@@ -2413,11 +2413,11 @@ ParserBase<Traits>::ParseAssignmentExpression(bool accept_IN,
   // Do not merge pending non-pattern expressions yet!
   classifier->Accumulate(
       &arrow_formals_classifier,
-      ExpressionClassifier::StandardProductions |
+      ExpressionClassifier::ExpressionProductions |
+          ExpressionClassifier::PatternProductions |
           ExpressionClassifier::FormalParametersProductions |
           ExpressionClassifier::CoverInitializedNameProduction |
-          ExpressionClassifier::AsyncArrowFormalParametersProduction |
-          ExpressionClassifier::AsyncBindingPatternProduction,
+          ExpressionClassifier::AsyncArrowFormalParametersProduction,
       false);
 
   if (!Token::IsAssignmentOp(peek())) {