Commit 7d482781 authored by ivica.bogosavljevic's avatar ivica.bogosavljevic Committed by Commit bot

MIPS: Fix compilation failures due to warnings on mips32r1

BUG=

Review-Url: https://codereview.chromium.org/2359923003
Cr-Commit-Position: refs/heads/master@{#39664}
parent e6c1081f
...@@ -5458,11 +5458,13 @@ void helper_madd_msub_maddf_msubf(F func) { ...@@ -5458,11 +5458,13 @@ void helper_madd_msub_maddf_msubf(F func) {
(CALL_GENERATED_CODE(isolate, f, &tc, 0, 0, 0, 0)); (CALL_GENERATED_CODE(isolate, f, &tc, 0, 0, 0, 0));
T res_add = tc.fr + (tc.fs * tc.ft); T res_add = tc.fr + (tc.fs * tc.ft);
T res_sub; T res_sub = 0;
if (IsMipsArchVariant(kMips32r2)) { if (IsMipsArchVariant(kMips32r2)) {
res_sub = (tc.fs * tc.ft) - tc.fr; res_sub = (tc.fs * tc.ft) - tc.fr;
} else if (IsMipsArchVariant(kMips32r6)) { } else if (IsMipsArchVariant(kMips32r6)) {
res_sub = tc.fr - (tc.fs * tc.ft); res_sub = tc.fr - (tc.fs * tc.ft);
} else {
UNREACHABLE();
} }
CHECK_EQ(tc.fd_add, res_add); CHECK_EQ(tc.fd_add, res_add);
......
...@@ -1180,6 +1180,9 @@ TEST_F(InstructionSelectorTest, Float64Abs) { ...@@ -1180,6 +1180,9 @@ TEST_F(InstructionSelectorTest, Float64Abs) {
} }
TEST_F(InstructionSelectorTest, Float32AddWithFloat32Mul) { TEST_F(InstructionSelectorTest, Float32AddWithFloat32Mul) {
if (!IsMipsArchVariant(kMips32r2) && !IsMipsArchVariant(kMips32r6)) {
return;
}
{ {
StreamBuilder m(this, MachineType::Float32(), MachineType::Float32(), StreamBuilder m(this, MachineType::Float32(), MachineType::Float32(),
MachineType::Float32(), MachineType::Float32()); MachineType::Float32(), MachineType::Float32());
...@@ -1243,6 +1246,9 @@ TEST_F(InstructionSelectorTest, Float32AddWithFloat32Mul) { ...@@ -1243,6 +1246,9 @@ TEST_F(InstructionSelectorTest, Float32AddWithFloat32Mul) {
} }
TEST_F(InstructionSelectorTest, Float64AddWithFloat64Mul) { TEST_F(InstructionSelectorTest, Float64AddWithFloat64Mul) {
if (!IsMipsArchVariant(kMips32r2) && !IsMipsArchVariant(kMips32r6)) {
return;
}
{ {
StreamBuilder m(this, MachineType::Float64(), MachineType::Float64(), StreamBuilder m(this, MachineType::Float64(), MachineType::Float64(),
MachineType::Float64(), MachineType::Float64()); MachineType::Float64(), MachineType::Float64());
...@@ -1311,7 +1317,12 @@ TEST_F(InstructionSelectorTest, Float32SubWithFloat32Mul) { ...@@ -1311,7 +1317,12 @@ TEST_F(InstructionSelectorTest, Float32SubWithFloat32Mul) {
Node* const p0 = m.Parameter(0); Node* const p0 = m.Parameter(0);
Node* const p1 = m.Parameter(1); Node* const p1 = m.Parameter(1);
Node* const p2 = m.Parameter(2); Node* const p2 = m.Parameter(2);
Node* n; Node* n = nullptr;
if (!IsMipsArchVariant(kMips32r2) && !IsMipsArchVariant(kMips32r6)) {
return;
}
if (IsMipsArchVariant(kMips32r2)) { if (IsMipsArchVariant(kMips32r2)) {
n = m.Float32Sub(m.Float32Mul(p1, p2), p0); n = m.Float32Sub(m.Float32Mul(p1, p2), p0);
} else if (IsMipsArchVariant(kMips32r6)) { } else if (IsMipsArchVariant(kMips32r6)) {
...@@ -1347,7 +1358,12 @@ TEST_F(InstructionSelectorTest, Float64SubWithFloat64Mul) { ...@@ -1347,7 +1358,12 @@ TEST_F(InstructionSelectorTest, Float64SubWithFloat64Mul) {
Node* const p0 = m.Parameter(0); Node* const p0 = m.Parameter(0);
Node* const p1 = m.Parameter(1); Node* const p1 = m.Parameter(1);
Node* const p2 = m.Parameter(2); Node* const p2 = m.Parameter(2);
Node* n; Node* n = nullptr;
if (!IsMipsArchVariant(kMips32r2) && !IsMipsArchVariant(kMips32r6)) {
return;
}
if (IsMipsArchVariant(kMips32r2)) { if (IsMipsArchVariant(kMips32r2)) {
n = m.Float64Sub(m.Float64Mul(p1, p2), p0); n = m.Float64Sub(m.Float64Mul(p1, p2), p0);
} else if (IsMipsArchVariant(kMips32r6)) { } else if (IsMipsArchVariant(kMips32r6)) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment