Commit 7b1138d2 authored by Yang Guo's avatar Yang Guo Committed by Commit Bot

[debug] deal with empty handles when checking callback info.

We may get an empty handle passed to the side-effect check in places
where we have not implemented the flag check yet.

R=luoe@chromium.org

Bug: v8:7515
Change-Id: I088b223c4e8cc3aa262bebe34458c2e95b30e347
Reviewed-on: https://chromium-review.googlesource.com/951768Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51783}
parent a9fcdd4a
...@@ -50,6 +50,8 @@ Handle<JSObject> PropertyCallbackArguments::CallIndexedEnumerator( ...@@ -50,6 +50,8 @@ Handle<JSObject> PropertyCallbackArguments::CallIndexedEnumerator(
bool PropertyCallbackArguments::PerformSideEffectCheck( bool PropertyCallbackArguments::PerformSideEffectCheck(
Isolate* isolate, Handle<Object> callback_info) { Isolate* isolate, Handle<Object> callback_info) {
// TODO(7515): always pass a valid callback info object.
if (callback_info.is_null()) return false;
return isolate->debug()->PerformSideEffectCheckForCallback(*callback_info); return isolate->debug()->PerformSideEffectCheckForCallback(*callback_info);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment