Commit 7a5b2339 authored by rmcilroy's avatar rmcilroy Committed by Commit bot

[Interpreter] Fix test-log-stack-tracer for Ignition.

BUG=v8:4680
LOG=N

Review URL: https://codereview.chromium.org/1692693004

Cr-Commit-Position: refs/heads/master@{#33930}
parent 2cfa0e89
...@@ -581,10 +581,6 @@ ...@@ -581,10 +581,6 @@
'test-run-jsexceptions/ThrowMessagePosition': [FAIL], 'test-run-jsexceptions/ThrowMessagePosition': [FAIL],
'test-api/TryCatchMixedNesting': [PASS, FAIL], 'test-api/TryCatchMixedNesting': [PASS, FAIL],
# TODO(rmcilroy,4689): Stack frame calling frame is_javascript() failure.
'test-log-stack-tracer/CFromJSStackTrace': [FAIL],
'test-log-stack-tracer/PureJSStackTrace': [FAIL],
# TODO(rmcilroy,4680): Exception message assert failure. # TODO(rmcilroy,4680): Exception message assert failure.
'test-api/CallICFastApi_SimpleSignature_Miss2WithProfiler': [PASS, FAIL], 'test-api/CallICFastApi_SimpleSignature_Miss2WithProfiler': [PASS, FAIL],
'test-api/InterceptorCallICFastApi_SimpleSignature_Miss3WithProfiler': [PASS, FAIL], 'test-api/InterceptorCallICFastApi_SimpleSignature_Miss3WithProfiler': [PASS, FAIL],
......
...@@ -83,6 +83,11 @@ static void construct_call(const v8::FunctionCallbackInfo<v8::Value>& args) { ...@@ -83,6 +83,11 @@ static void construct_call(const v8::FunctionCallbackInfo<v8::Value>& args) {
frame_iterator.Advance(); frame_iterator.Advance();
CHECK(frame_iterator.frame()->is_construct()); CHECK(frame_iterator.frame()->is_construct());
frame_iterator.Advance(); frame_iterator.Advance();
if (i::FLAG_ignition) {
// Skip over bytecode handler frame.
CHECK(frame_iterator.frame()->type() == i::StackFrame::STUB);
frame_iterator.Advance();
}
i::StackFrame* calling_frame = frame_iterator.frame(); i::StackFrame* calling_frame = frame_iterator.frame();
CHECK(calling_frame->is_java_script()); CHECK(calling_frame->is_java_script());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment