Commit 7a02c728 authored by zhengxing.li's avatar zhengxing.li Committed by Commit bot

X87: Reland: [Crankshaft] Always check for stubs marked to not require an eager frame.

  port 1b4e0130(r37181)

  original commit message:
  Previously only stubs built in the snapshot were checked for having an
  eager frame. This caused a regression to creap in on ia32 for
  RegExpConstructResultStub. Change test to always check.

BUG=

Review-Url: https://codereview.chromium.org/2098303003
Cr-Commit-Position: refs/heads/master@{#37320}
parent 90fa326a
...@@ -470,7 +470,7 @@ HValue* CodeStubGraphBuilder<FastCloneShallowArrayStub>::BuildCodeStub() { ...@@ -470,7 +470,7 @@ HValue* CodeStubGraphBuilder<FastCloneShallowArrayStub>::BuildCodeStub() {
// TODO(turbofan): This codestub has regressed to need a frame on ia32 at some // TODO(turbofan): This codestub has regressed to need a frame on ia32 at some
// point and wasn't caught since it wasn't built in the snapshot. We should // point and wasn't caught since it wasn't built in the snapshot. We should
// probably just replace with a TurboFan stub rather than fixing it. // probably just replace with a TurboFan stub rather than fixing it.
#if !V8_TARGET_ARCH_IA32 #if !(V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X87)
// This stub is very performance sensitive, the generated code must be tuned // This stub is very performance sensitive, the generated code must be tuned
// so that it doesn't build and eager frame. // so that it doesn't build and eager frame.
info()->MarkMustNotHaveEagerFrame(); info()->MarkMustNotHaveEagerFrame();
...@@ -2069,7 +2069,7 @@ HValue* CodeStubGraphBuilder<RegExpConstructResultStub>::BuildCodeStub() { ...@@ -2069,7 +2069,7 @@ HValue* CodeStubGraphBuilder<RegExpConstructResultStub>::BuildCodeStub() {
// TODO(turbofan): This codestub has regressed to need a frame on ia32 at some // TODO(turbofan): This codestub has regressed to need a frame on ia32 at some
// point and wasn't caught since it wasn't built in the snapshot. We should // point and wasn't caught since it wasn't built in the snapshot. We should
// probably just replace with a TurboFan stub rather than fixing it. // probably just replace with a TurboFan stub rather than fixing it.
#if !V8_TARGET_ARCH_IA32 #if !(V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X87)
info()->MarkMustNotHaveEagerFrame(); info()->MarkMustNotHaveEagerFrame();
#endif #endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment