[compiler] Fix typo in IfValueParameters operator==

Change-Id: I2c1dfb7fbcf9a23d9e156dc3918fb88140885195
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2614721Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Paolo Severini <paolosev@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#72003}

src/compiler/common-operator.cc

@@ -441,7 +441,7 @@ ZoneVector<MachineType> const* MachineTypesOf(Operator const* op) {
 V8_EXPORT_PRIVATE bool operator==(IfValueParameters const& l,
                                   IfValueParameters const& r) {
   return l.value() == r.value() &&
-         r.comparison_order() == r.comparison_order() && l.hint() == r.hint();
+         l.comparison_order() == r.comparison_order() && l.hint() == r.hint();
 }
 
 size_t hash_value(IfValueParameters const& p) {

test/unittests/compiler/common-operator-unittest.cc

@@ -248,6 +248,12 @@ TEST_F(CommonOperatorTest, IfValue) {
       EXPECT_EQ(1, op->ControlOutputCount());
     }
   }
+
+  // Specific test for a regression in the IfValueParameters operator==.
+  CHECK(!(IfValueParameters(0, 0) == IfValueParameters(1, 0)));
+  CHECK(!(IfValueParameters(0, 0) == IfValueParameters(0, 1)));
+  CHECK(!(IfValueParameters(0, 1, BranchHint::kFalse) ==
+          IfValueParameters(0, 1, BranchHint::kTrue)));
 }