[turbofan] Clarify purpose of bytecode_array in InlinedFunctionHolder

Change-Id: I7716dab4d6d0ff582acdffb988a05429bccab2ad
Reviewed-on: https://chromium-review.googlesource.com/c/1462006
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59554}

src/compiler/js-inlining.cc

@@ -465,10 +465,6 @@ Reduction JSInliner::ReduceJSCall(Node* node) {
         info_->shared_info()->DebugName()->ToCString().get(),
         (exception_target != nullptr) ? " (inside try-block)" : "");
 
-  // Get the bytecode array.
-  Handle<BytecodeArray> bytecode_array =
-      handle(shared_info->GetBytecodeArray(), isolate());
-
   // Determine the targets feedback vector and its context.
   Node* context;
   Handle<FeedbackVector> feedback_vector;
@@ -485,6 +481,9 @@ Reduction JSInliner::ReduceJSCall(Node* node) {
     }
   }
 
+  Handle<BytecodeArray> bytecode_array =
+      handle(shared_info->GetBytecodeArray(), isolate());
+
   // Remember that we inlined this function.
   int inlining_id = info_->AddInlinedFunction(
       shared_info, bytecode_array, source_positions_->GetSourcePosition(node));

src/optimized-compilation-info.cc

@@ -203,5 +203,15 @@ void OptimizedCompilationInfo::SetTracingFlags(bool passes_filter) {
   if (FLAG_trace_turbo_scheduled) SetFlag(kTraceTurboScheduled);
 }
 
+OptimizedCompilationInfo::InlinedFunctionHolder::InlinedFunctionHolder(
+    Handle<SharedFunctionInfo> inlined_shared_info,
+    Handle<BytecodeArray> inlined_bytecode, SourcePosition pos)
+    : shared_info(inlined_shared_info), bytecode_array(inlined_bytecode) {
+  DCHECK_EQ(shared_info->GetBytecodeArray(), *bytecode_array);
+  position.position = pos;
+  // initialized when generating the deoptimization literals
+  position.inlined_function_id = DeoptimizationData::kNotInlinedIndex;
+}
+
 }  // namespace internal
 }  // namespace v8

src/optimized-compilation-info.h

@@ -232,18 +232,12 @@ class V8_EXPORT_PRIVATE OptimizedCompilationInfo final {
 
   struct InlinedFunctionHolder {
     Handle<SharedFunctionInfo> shared_info;
-    Handle<BytecodeArray> bytecode_array;
-
+    Handle<BytecodeArray> bytecode_array;  // Explicit to prevent flushing.
     InliningPosition position;
 
     InlinedFunctionHolder(Handle<SharedFunctionInfo> inlined_shared_info,
                           Handle<BytecodeArray> inlined_bytecode,
-                          SourcePosition pos)
-        : shared_info(inlined_shared_info), bytecode_array(inlined_bytecode) {
-      position.position = pos;
-      // initialized when generating the deoptimization literals
-      position.inlined_function_id = DeoptimizationData::kNotInlinedIndex;
-    }
+                          SourcePosition pos);
 
     void RegisterInlinedFunctionId(size_t inlined_function_id) {
       position.inlined_function_id = static_cast<int>(inlined_function_id);