Commit 789bfeb3 authored by Benedikt Meurer's avatar Benedikt Meurer Committed by Commit Bot

[turbofan] Remove ExternalPointer hack from SimplifiedLowering.

This is no longer necessary as the JSFunction::code field is now a
proper tagged field, that points to a Code object, instead of a
naked pointer into the beginning of the Code object. So now the
representation selection always sees a proper tagged value here.

Bug: v8:8015
Change-Id: Ia66e9425d82a0f765e4cbb6e3bed7bcdd9438958
Reviewed-on: https://chromium-review.googlesource.com/1196662Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55524}
parent ab37324c
...@@ -1062,12 +1062,6 @@ class RepresentationSelector { ...@@ -1062,12 +1062,6 @@ class RepresentationSelector {
if (type.IsNone()) { if (type.IsNone()) {
return MachineType::None(); return MachineType::None();
} }
// TODO(turbofan): Special treatment for ExternalPointer here,
// to avoid incompatible truncations. We really need a story
// for the JSFunction::entry field.
if (type.Is(Type::ExternalPointer())) {
return MachineType::Pointer();
}
// Do not distinguish between various Tagged variations. // Do not distinguish between various Tagged variations.
if (IsAnyTagged(rep)) { if (IsAnyTagged(rep)) {
return MachineType::AnyTagged(); return MachineType::AnyTagged();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment