Commit 77f9b287 authored by Maya Lekova's avatar Maya Lekova Committed by Commit Bot

Revert "[ptr-compr][x64] Temporarily enable pointer compression on x64"

This reverts commit 589d1a6b.

Reason for revert: Breaking UBSan - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/5219

Original change's description:
> [ptr-compr][x64] Temporarily enable pointer compression on x64
> 
> ... and make sure that the x64 ptr-compr bots proceed testing V8 without
> pointer compression in order to keep testing the full pointer mode.
> 
> Bug: v8:7703
> Change-Id: Iee725deda813425a6f0722948b54976154f50909
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1497139
> Reviewed-by: Michael Hablich <hablich@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#60230}

TBR=machenbach@chromium.org,hablich@chromium.org,ishell@chromium.org,verwaest@chromium.org

Change-Id: I5a9f04acba1ef23ae944d97a029ea018808c7fcb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7703
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1522991Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60231}
parent 589d1a6b
...@@ -95,7 +95,7 @@ declare_args() { ...@@ -95,7 +95,7 @@ declare_args() {
v8_enable_verify_csa = false v8_enable_verify_csa = false
# Enable pointer compression (sets -dV8_COMPRESS_POINTERS). # Enable pointer compression (sets -dV8_COMPRESS_POINTERS).
v8_enable_pointer_compression = "" v8_enable_pointer_compression = false
v8_enable_31bit_smis_on_64bit_arch = false v8_enable_31bit_smis_on_64bit_arch = false
# Sets -dOBJECT_PRINT. # Sets -dOBJECT_PRINT.
...@@ -206,11 +206,6 @@ if (v8_check_microtasks_scopes_consistency == "") { ...@@ -206,11 +206,6 @@ if (v8_check_microtasks_scopes_consistency == "") {
v8_enable_debugging_features || dcheck_always_on v8_enable_debugging_features || dcheck_always_on
} }
if (v8_enable_pointer_compression == "") {
# TODO(v8:v7703): temporarily enable pointer compression on x64
v8_enable_pointer_compression = v8_target_cpu == "x64"
}
assert(v8_current_cpu != "x86" || !v8_untrusted_code_mitigations, assert(v8_current_cpu != "x86" || !v8_untrusted_code_mitigations,
"Untrusted code mitigations are unsupported on ia32") "Untrusted code mitigations are unsupported on ia32")
......
...@@ -450,10 +450,7 @@ ...@@ -450,10 +450,7 @@
'release_bot', 'x64', 'minimal_symbols'], 'release_bot', 'x64', 'minimal_symbols'],
'release_x64_pointer_compression': [ 'release_x64_pointer_compression': [
'release_bot', 'x64', 'dcheck_always_on', 'v8_enable_slow_dchecks', 'release_bot', 'x64', 'dcheck_always_on', 'v8_enable_slow_dchecks',
# TODO(v8:v7703): Make pointer compression bots testing non pointer 'v8_enable_pointer_compression'],
# compression mode while pointer compression is temporarily enabled
# on x64
'v8_disable_pointer_compression'],
'release_x64_trybot': [ 'release_x64_trybot': [
'release_trybot', 'x64'], 'release_trybot', 'x64'],
'release_x64_test_features_trybot': [ 'release_x64_test_features_trybot': [
...@@ -810,10 +807,6 @@ ...@@ -810,10 +807,6 @@
'gn_args': 'v8_enable_pointer_compression=true', 'gn_args': 'v8_enable_pointer_compression=true',
}, },
'v8_disable_pointer_compression': {
'gn_args': 'v8_enable_pointer_compression=false',
},
'v8_enable_test_features': { 'v8_enable_test_features': {
'gn_args': 'v8_enable_test_features=true', 'gn_args': 'v8_enable_test_features=true',
}, },
......
This diff is collapsed.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment