Commit 770e12aa authored by Dominik Inführ's avatar Dominik Inführ Committed by Commit Bot

[heap] Emit more info for evacuation with tracing

Emit live bytes and evacuation mode as text for evacuated pages. Also
emit the number of evacuated pages.

Change-Id: Iadf1ac60f4fd35774f879277efb0b83fac39dd63
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2273136Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68609}
parent 9dd7a303
...@@ -2856,6 +2856,19 @@ class Evacuator : public Malloced { ...@@ -2856,6 +2856,19 @@ class Evacuator : public Malloced {
kPageNewToNew, kPageNewToNew,
}; };
static const char* EvacuationModeName(EvacuationMode mode) {
switch (mode) {
case kObjectsNewToOld:
return "objects-new-to-old";
case kPageNewToOld:
return "page-new-to-old";
case kObjectsOldToOld:
return "objects-old-to-old";
case kPageNewToNew:
return "page-new-to-new";
}
}
static inline EvacuationMode ComputeEvacuationMode(MemoryChunk* chunk) { static inline EvacuationMode ComputeEvacuationMode(MemoryChunk* chunk) {
// Note: The order of checks is important in this function. // Note: The order of checks is important in this function.
if (chunk->IsFlagSet(MemoryChunk::PAGE_NEW_OLD_PROMOTION)) if (chunk->IsFlagSet(MemoryChunk::PAGE_NEW_OLD_PROMOTION))
...@@ -3029,12 +3042,12 @@ class FullEvacuator : public Evacuator { ...@@ -3029,12 +3042,12 @@ class FullEvacuator : public Evacuator {
void FullEvacuator::RawEvacuatePage(MemoryChunk* chunk, intptr_t* live_bytes) { void FullEvacuator::RawEvacuatePage(MemoryChunk* chunk, intptr_t* live_bytes) {
const EvacuationMode evacuation_mode = ComputeEvacuationMode(chunk); const EvacuationMode evacuation_mode = ComputeEvacuationMode(chunk);
TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("v8.gc"),
"FullEvacuator::RawEvacuatePage", "evacuation_mode",
evacuation_mode);
MarkCompactCollector::NonAtomicMarkingState* marking_state = MarkCompactCollector::NonAtomicMarkingState* marking_state =
collector_->non_atomic_marking_state(); collector_->non_atomic_marking_state();
*live_bytes = marking_state->live_bytes(chunk); *live_bytes = marking_state->live_bytes(chunk);
TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("v8.gc"),
"FullEvacuator::RawEvacuatePage", "evacuation_mode",
EvacuationModeName(evacuation_mode), "live_bytes", *live_bytes);
HeapObject failed_object; HeapObject failed_object;
switch (evacuation_mode) { switch (evacuation_mode) {
case kObjectsNewToOld: case kObjectsNewToOld:
...@@ -3217,6 +3230,10 @@ void MarkCompactCollector::EvacuatePagesInParallel() { ...@@ -3217,6 +3230,10 @@ void MarkCompactCollector::EvacuatePagesInParallel() {
if (evacuation_job.NumberOfItems() == 0) return; if (evacuation_job.NumberOfItems() == 0) return;
TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("v8.gc"),
"MarkCompactCollector::EvacuatePagesInParallel", "pages",
evacuation_job.NumberOfItems());
CreateAndExecuteEvacuationTasks<FullEvacuator>(this, &evacuation_job, nullptr, CreateAndExecuteEvacuationTasks<FullEvacuator>(this, &evacuation_job, nullptr,
live_bytes); live_bytes);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment