Commit 764b4095 authored by Adam Klein's avatar Adam Klein Committed by Commit Bot

[testrunner] Remove last use of 'simulator' and its handling code

'simulator_run' is now used exclusively in test/*/*.status.

Change-Id: I501b7ffd19e2476f4c803ed3d25cba69d67039fa
Reviewed-on: https://chromium-review.googlesource.com/c/1318610Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57300}
parent 007c0034
...@@ -86,7 +86,7 @@ ...@@ -86,7 +86,7 @@
# Issue 488: this test sometimes times out. # Issue 488: this test sometimes times out.
# TODO(arm): This seems to flush out a bug on arm with simulator. # TODO(arm): This seems to flush out a bug on arm with simulator.
'array-constructor': [PASS, SLOW, ['arch == arm and simulator == True', SKIP]], 'array-constructor': [PASS, SLOW, ['arch == arm and simulator_run == True', SKIP]],
# Very slow test # Very slow test
'regress/regress-crbug-808192' : [PASS, SLOW, NO_VARIANTS, ['mode == debug or arch == arm or arch == arm64 or arch == android_arm or arch == android_arm64 or arch == mipsel or arch == mips64el or arch == mips64 or arch == mips or arch == s390 or arch == s390x or arch == ppc or arch == ppc64', SKIP]], 'regress/regress-crbug-808192' : [PASS, SLOW, NO_VARIANTS, ['mode == debug or arch == arm or arch == arm64 or arch == android_arm or arch == android_arm64 or arch == mipsel or arch == mips64el or arch == mips64 or arch == mips or arch == s390 or arch == s390x or arch == ppc or arch == ppc64', SKIP]],
......
...@@ -52,14 +52,14 @@ ...@@ -52,14 +52,14 @@
# Too slow with --enable-slow-asserts. # Too slow with --enable-slow-asserts.
'array-iterate-backwards': [SKIP], 'array-iterate-backwards': [SKIP],
}], # 'mode == debug' }], # 'mode == debug'
['simulator', { ['simulator_run', {
# Skip tests that timeout with turbofan. # Skip tests that timeout with turbofan.
'array-iterate-backwards': [PASS, NO_VARIANTS], 'array-iterate-backwards': [PASS, NO_VARIANTS],
'function-apply-aliased': [SKIP], 'function-apply-aliased': [SKIP],
# Skip tests that are too slow for simulators. # Skip tests that are too slow for simulators.
'dfg-int-overflow-in-loop': [SKIP], 'dfg-int-overflow-in-loop': [SKIP],
}], # 'simulator' }], # 'simulator_run'
['arch == arm64 and simulator_run', { ['arch == arm64 and simulator_run', {
'dfg-int-overflow-in-loop': [SKIP], 'dfg-int-overflow-in-loop': [SKIP],
}], # 'arch == arm64 and simulator_run' }], # 'arch == arm64 and simulator_run'
......
...@@ -635,7 +635,6 @@ class BaseTestRunner(object): ...@@ -635,7 +635,6 @@ class BaseTestRunner(object):
self.build_config.arch in ['mipsel', 'mips', 'mips64', 'mips64el'] and self.build_config.arch in ['mipsel', 'mips', 'mips64', 'mips64el'] and
self.build_config.mips_arch_variant) self.build_config.mips_arch_variant)
# TODO(all): Combine "simulator" and "simulator_run".
# TODO(machenbach): In GN we can derive simulator run from # TODO(machenbach): In GN we can derive simulator run from
# target_arch != v8_target_arch in the dumped build config. # target_arch != v8_target_arch in the dumped build config.
return { return {
...@@ -658,7 +657,6 @@ class BaseTestRunner(object): ...@@ -658,7 +657,6 @@ class BaseTestRunner(object):
"novfp3": False, "novfp3": False,
"predictable": self.build_config.predictable, "predictable": self.build_config.predictable,
"simd_mips": simd_mips, "simd_mips": simd_mips,
"simulator": utils.UseSimulator(self.build_config.arch),
"simulator_run": False, "simulator_run": False,
"system": self.target_os, "system": self.target_os,
"tsan": self.build_config.tsan, "tsan": self.build_config.tsan,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment