Commit 762d689c authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

[foozzie] Add suppression for .caller

NOTRY=true

Bug: chromium:718739
Change-Id: Ie28b3848a3809473d6c8757e7a86e3a786483ef1
Reviewed-on: https://chromium-review.googlesource.com/506090Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45317}
parent 61109b9e
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
# Compared x64,ignition with x64,ignition_turbo # Compared x64,ignition with x64,ignition_turbo
# #
# Flags of x64,ignition: # Flags of x64,ignition:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed 12345 --ignition --turbo-filter=~ --hydrogen-filter=~ --nocrankshaft --abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed 12345 --ignition --turbo-filter=~ --hydrogen-filter=~ --noopt
# Flags of x64,ignition_turbo: # Flags of x64,ignition_turbo:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed 12345 --ignition --turbo --abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed 12345 --ignition --turbo
# #
......
...@@ -3,3 +3,4 @@ ...@@ -3,3 +3,4 @@
// found in the LICENSE file. // found in the LICENSE file.
// Empty test dummy. // Empty test dummy.
print("js-mutation: start generated test case");
...@@ -46,6 +46,11 @@ IGNORE_SOURCES = { ...@@ -46,6 +46,11 @@ IGNORE_SOURCES = {
'/v8/test/mjsunit/regress/regress-2989.js', '/v8/test/mjsunit/regress/regress-2989.js',
], ],
'crbug.com/718739': [
'/v8/test/mjsunit/regress/regress-105.js',
'/v8/test/mjsunit/regress/regress-crbug-599714.js',
],
'crbug.com/688159': [ 'crbug.com/688159': [
'/v8/test/mjsunit/es7/exponentiation-operator.js', '/v8/test/mjsunit/es7/exponentiation-operator.js',
], ],
...@@ -62,16 +67,9 @@ IGNORE_SOURCES = { ...@@ -62,16 +67,9 @@ IGNORE_SOURCES = {
} }
# Ignore by test case pattern. Map from bug->regexp. # Ignore by test case pattern. Map from bug->regexp.
# Regular expressions are assumed to be compiled. We use regexp.match. # Regular expressions are assumed to be compiled. We use regexp.search.
# Make sure the code doesn't match in the preamble portion of the test case
# (i.e. in the modified inlined mjsunit.js). You can reference the comment
# between the two parts like so:
# 'crbug.com/666308':
# re.compile(r'.*End stripped down and modified version.*'
# r'\.prototype.*instanceof.*.*', re.S)
# TODO(machenbach): Insert a JS sentinel between the two parts, because
# comments are stripped during minimization.
IGNORE_TEST_CASES = { IGNORE_TEST_CASES = {
'crbug.com/718739': re.compile(r'\.caller'),
} }
# Ignore by output pattern. Map from config->bug->regexp. Config '' is used # Ignore by output pattern. Map from config->bug->regexp. Config '' is used
...@@ -277,8 +275,12 @@ class V8Suppression(Suppression): ...@@ -277,8 +275,12 @@ class V8Suppression(Suppression):
) )
def ignore_by_content(self, testcase): def ignore_by_content(self, testcase):
# Strip off test case preamble.
lines = testcase.splitlines()
lines = lines[lines.index('print("js-mutation: start generated test case");'):]
content = '\n'.join(lines)
for bug, exp in IGNORE_TEST_CASES.iteritems(): for bug, exp in IGNORE_TEST_CASES.iteritems():
if exp.match(testcase): if exp.search(content):
return bug return bug
return False return False
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment