Commit 75a4ddc9 authored by Leszek Swirski's avatar Leszek Swirski Committed by V8 LUCI CQ

Revert "Build cctest while building V8"

This reverts commit 7787ed20.

Reason for revert: Seems to break the archive bot (https://ci.chromium.org/ui/p/chromium/builders/ci/linux-archive-dbg/b8811978830853167601/overview)

Original change's description:
> Build cctest while building V8
>
> I noticed in a recent build that C++ files from cctest didn't start
> compiling until after several slow non-parallel tasks such as running
> mksnapshot and linking v8_for_testing. I don't see any reason that
> cctest sources should wait for those tasks, so in this change I propose
> adjusting the build dependencies for more parallelism.
>
> Change-Id: I2472117c8555ac397fa1232954c8b699d6429d38
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3690170
> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#80976}

Change-Id: I1d22362080962b424c21232f63e8896a2cbe2bb4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3695357
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81025}
parent e831949f
......@@ -16,13 +16,7 @@ v8_executable("cctest") {
sources = [ "cctest.cc" ]
deps = [
":cctest_sources",
"../..:v8_for_testing",
"../..:v8_libbase",
"../..:v8_libplatform",
"../../tools/debug_helper:v8_debug_helper",
]
deps = [ ":cctest_sources" ]
data_deps = [ "../../tools:v8_testrunner" ]
......@@ -346,6 +340,10 @@ v8_source_set("cctest_sources") {
public_deps = [
":cctest_headers",
"..:common_test_headers",
"../..:v8_for_testing",
"../..:v8_libbase",
"../..:v8_libplatform",
"../../tools/debug_helper:v8_debug_helper",
"//build/win:default_exe_manifest",
]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment