Commit 750a6f72 authored by Yang Guo's avatar Yang Guo Committed by Commit Bot

Revert "[node] accept multiple --extra-gn-args"

This reverts commit 91344c5f.

The original commit seems to cause some issues.

TBR=machenbach@chromium.org

Change-Id: I2ee3f635ad8c2edd78c4c645c075c4153fb8a8ee
Reviewed-on: https://chromium-review.googlesource.com/c/1452440Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59350}
parent b2610249
......@@ -67,10 +67,9 @@ def GenerateBuildFiles(options):
else:
gn_args.append("is_debug=false")
for arg in options.extra_gn_args:
gn_args.append(arg)
flattened_args = ' '.join(gn_args)
if options.extra_gn_args:
flattened_args += ' ' + options.extra_gn_args
args = [gn, "gen", options.build_path, "-q", "--args=" + flattened_args]
subprocess.check_call(args)
......@@ -107,8 +106,7 @@ def ParseOptions(args):
parser.add_argument("--bundled-win-toolchain-root",
help="Value for DEPOT_TOOLS_WIN_TOOLCHAIN_ROOT")
parser.add_argument("--depot-tools", help="Absolute path to depot_tools")
parser.add_argument("--extra-gn-args", help="Additional GN args",
action="append")
parser.add_argument("--extra-gn-args", help="Additional GN args")
parser.add_argument("--build", help="Run ninja as opposed to gn gen.",
action="store_true")
parser.add_argument("--max-jobs", help="ninja's -j parameter")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment