Commit 75020297 authored by bmeurer's avatar bmeurer Committed by Commit bot

[turbofan] Fix typed lowering of JSConvertReceiver.

We lowered JSConvertReceiver using JSToObject, w/o connecting the
JSToObject to the control chain (which is fine since that ToObject
cannot throw). But then the lowering of the JSToObject would insert
an IfSuccess, which is immediately dead, since it is not used. This
was fine in a sense that it didn't seem to crash anything, but we
now want to do more aggressive checking if IfSuccess/IfException
nodes and so we need to fix this sloppyness in the lowerings.

R=mstarzinger@chromium.org

Review-Url: https://codereview.chromium.org/2228783003
Cr-Commit-Position: refs/heads/master@{#38484}
parent b531266d
...@@ -690,11 +690,11 @@ const Operator* JSOperatorBuilder::CallConstruct( ...@@ -690,11 +690,11 @@ const Operator* JSOperatorBuilder::CallConstruct(
const Operator* JSOperatorBuilder::ConvertReceiver( const Operator* JSOperatorBuilder::ConvertReceiver(
ConvertReceiverMode convert_mode) { ConvertReceiverMode convert_mode) {
return new (zone()) Operator1<ConvertReceiverMode>( // -- return new (zone()) Operator1<ConvertReceiverMode>( // --
IrOpcode::kJSConvertReceiver, Operator::kNoThrow, // opcode IrOpcode::kJSConvertReceiver, Operator::kEliminatable, // opcode
"JSConvertReceiver", // name "JSConvertReceiver", // name
1, 1, 1, 1, 1, 0, // counts 1, 1, 1, 1, 1, 0, // counts
convert_mode); // parameter convert_mode); // parameter
} }
const Operator* JSOperatorBuilder::LoadNamed(Handle<Name> name, const Operator* JSOperatorBuilder::LoadNamed(Handle<Name> name,
......
This diff is collapsed.
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment