[heap] Fix flaky test failure in concurrent allocation

Concurrent allocation test was failing flakily. Do not fix this simply
by increasing heap size since this would reduce frequency of GCs.
Instead allow allocations to fail. Even in this case the allocation
code path is still executed which we want to test.

Bug: v8:11084, v8:10315
Change-Id: I0daa9ad9177aab8b02b7decf2ccfd50e0d8ab9b6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2516471Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70946}

src/heap/local-heap.cc

@@ -160,6 +160,11 @@ void LocalHeap::UnmarkLinearAllocationArea() {
   old_space_allocator_.UnmarkLinearAllocationArea();
 }
 
+void LocalHeap::PerformCollection() {
+  ParkedScope scope(this);
+  heap_->RequestCollectionBackground(this);
+}
+
 Address LocalHeap::PerformCollectionAndAllocateAgain(
     int object_size, AllocationType type, AllocationOrigin origin,
     AllocationAlignment alignment) {
@@ -167,10 +172,7 @@ Address LocalHeap::PerformCollectionAndAllocateAgain(
   static const int kMaxNumberOfRetries = 3;
 
   for (int i = 0; i < kMaxNumberOfRetries; i++) {
-    {
-      ParkedScope scope(this);
-      heap_->RequestCollectionBackground(this);
-    }
+    PerformCollection();
 
     AllocationResult result = AllocateRaw(object_size, type, origin, alignment);
     if (!result.IsRetry()) {

src/heap/local-heap.h

@@ -128,6 +128,9 @@ class V8_EXPORT_PRIVATE LocalHeap {
 
   bool is_main_thread() const { return is_main_thread_; }
 
+  // Requests GC and blocks until the collection finishes.
+  void PerformCollection();
+
  private:
   enum class ThreadState {
     // Threads in this state need to be stopped in a safepoint.

test/cctest/heap/test-concurrent-allocation.cc

@@ -149,10 +149,15 @@ class LargeObjectConcurrentAllocationThread final : public v8::base::Thread {
     const size_t kLargeObjectSize = kMaxRegularHeapObjectSize * 2;
 
     for (int i = 0; i < kNumIterations; i++) {
-      Address address = local_heap.AllocateRawOrFail(
+      AllocationResult result = local_heap.AllocateRaw(
           kLargeObjectSize, AllocationType::kOld, AllocationOrigin::kRuntime,
           AllocationAlignment::kWordAligned);
-      CreateFixedArray(heap_, address, kLargeObjectSize);
+      if (result.IsRetry()) {
+        local_heap.PerformCollection();
+      } else {
+        Address address = result.ToAddress();
+        CreateFixedArray(heap_, address, kLargeObjectSize);
+      }
       local_heap.Safepoint();
     }