Commit 708610e9 authored by hpayer's avatar hpayer Committed by Commit bot

Print finalize incremental marking event in idle notification.

BUG=

Review URL: https://codereview.chromium.org/775013002

Cr-Commit-Position: refs/heads/master@{#25631}
parent 7ec1c361
......@@ -29,6 +29,9 @@ void GCIdleTimeAction::Print() {
case DO_INCREMENTAL_MARKING:
PrintF("incremental marking with step %" V8_PTR_PREFIX "d / ms",
parameter);
if (additional_work) {
PrintF("; finalized marking");
}
break;
case DO_SCAVENGE:
PrintF("scavenge");
......
......@@ -26,6 +26,7 @@ class GCIdleTimeAction {
GCIdleTimeAction result;
result.type = DONE;
result.parameter = 0;
result.additional_work = false;
return result;
}
......@@ -33,6 +34,7 @@ class GCIdleTimeAction {
GCIdleTimeAction result;
result.type = DO_NOTHING;
result.parameter = 0;
result.additional_work = false;
return result;
}
......@@ -40,6 +42,7 @@ class GCIdleTimeAction {
GCIdleTimeAction result;
result.type = DO_INCREMENTAL_MARKING;
result.parameter = step_size;
result.additional_work = false;
return result;
}
......@@ -47,6 +50,7 @@ class GCIdleTimeAction {
GCIdleTimeAction result;
result.type = DO_SCAVENGE;
result.parameter = 0;
result.additional_work = false;
return result;
}
......@@ -54,6 +58,7 @@ class GCIdleTimeAction {
GCIdleTimeAction result;
result.type = DO_FULL_GC;
result.parameter = 0;
result.additional_work = false;
return result;
}
......@@ -61,6 +66,7 @@ class GCIdleTimeAction {
GCIdleTimeAction result;
result.type = DO_FINALIZE_SWEEPING;
result.parameter = 0;
result.additional_work = false;
return result;
}
......@@ -68,6 +74,7 @@ class GCIdleTimeAction {
GCIdleTimeActionType type;
intptr_t parameter;
bool additional_work;
};
......
......@@ -4409,7 +4409,7 @@ void Heap::IdleMarkCompact(const char* message) {
}
void Heap::TryFinalizeIdleIncrementalMarking(
bool Heap::TryFinalizeIdleIncrementalMarking(
double idle_time_in_ms, size_t size_of_objects,
size_t final_incremental_mark_compact_speed_in_bytes_per_ms) {
if (incremental_marking()->IsComplete() ||
......@@ -4418,7 +4418,9 @@ void Heap::TryFinalizeIdleIncrementalMarking(
static_cast<size_t>(idle_time_in_ms), size_of_objects,
final_incremental_mark_compact_speed_in_bytes_per_ms))) {
CollectAllGarbage(kNoGCFlags, "idle notification: finalize incremental");
return true;
}
return false;
}
......@@ -4503,7 +4505,7 @@ bool Heap::IdleNotification(double deadline_in_seconds) {
!incremental_marking()->IsComplete() &&
!mark_compact_collector_.marking_deque()->IsEmpty());
if (remaining_idle_time_in_ms > 0.0) {
TryFinalizeIdleIncrementalMarking(
action.additional_work = TryFinalizeIdleIncrementalMarking(
remaining_idle_time_in_ms, heap_state.size_of_objects,
heap_state.final_incremental_mark_compact_speed_in_bytes_per_ms);
}
......
......@@ -2010,7 +2010,7 @@ class Heap {
void IdleMarkCompact(const char* message);
void TryFinalizeIdleIncrementalMarking(
bool TryFinalizeIdleIncrementalMarking(
double idle_time_in_ms, size_t size_of_objects,
size_t mark_compact_speed_in_bytes_per_ms);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment