Commit 705cb7fb authored by caitpotter88's avatar caitpotter88 Committed by Commit bot

[esnext] add microbenchmarks for Object.values(), Object.entries()

Add microbenchmark for these methods.
BUG=v8:4663
LOG=N
R=adamk@chromium.org, littledan@chrommium.org

Review URL: https://codereview.chromium.org/1746383003

Cr-Commit-Position: refs/heads/master@{#34556}
parent 4db396b1
......@@ -108,12 +108,21 @@
},
{
"name": "Object",
"path": ["Object"],
"path": ["."],
"main": "run.js",
"resources": ["assign.js"],
"flags": ["--harmony"],
"resources": [
"assign.js",
"values.js",
"entries.js"
],
"results_regexp": "^%s\\-Object\\(Score\\): (.+)$",
"tests": [
{"name": "Assign"}
{"name": "Assign"},
{"name": "Entries"},
{"name": "EntriesMegamorphic"},
{"name": "Values"},
{"name": "ValuesMegamorphic"}
]
},
{
......
{
"name": "ObjectTests",
"run_count": 5,
"run_count_android_arm": 3,
"run_count_android_arm64": 3,
"timeout": 120,
"units": "score",
"total": true,
"resources": ["base.js"],
"tests": [
{
"name": "Object",
"path": ["."],
"main": "run.js",
"flags": ["--harmony"],
"resources": [
"assign.js",
"values.js",
"entries.js"
],
"results_regexp": "^%s\\-Object\\(Score\\): (.+)$",
"tests": [
{"name": "Assign"},
{"name": "Entries"},
{"name": "EntriesMegamorphic"},
{"name": "Values"},
{"name": "ValuesMegamorphic"}
]
}
]
}
// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
new BenchmarkSuite('Entries', [1000], [
new Benchmark('Basic', false, false, 0, Basic, BasicSetup, BasicTearDown)
]);
var object;
var expected;
var result;
var symbol1;
function Basic() {
result = Object.entries(object);
}
function BasicSetup() {
result = undefined;
symbol1 = Symbol('test');
object = { a: 10 };
object[26.0] = 'third';
object.b = 72;
object[symbol1] = 'TEST';
Object.defineProperty(object, 'not-enumerable', {
enumerable: false, value: 'nope', writable: true, configurable: true });
}
function BasicTearDown() {
result = result.map(entry => `[${[String(entry[0]), String(entry[1])]}]`);
return result.length === 3 &&
result.join(', ') === '[a, 10], [26.0, third], [b, 72]';
}
// ----------------------------------------------------------------------------
new BenchmarkSuite('EntriesMegamorphic', [1000], [
new Benchmark('BasicMegamorphic', false, false, 0, BasicMegamorphic,
BasicMegamorphicSetup, BasicMegamorphicTearDown)
]);
function BasicMegamorphic() {
for (var i = 0; i < object.length; ++i) {
result[i] = Object.entries(object[i]);
}
}
function BasicMegamorphicSetup() {
// Create 1k objects with different maps.
object = [];
expected = [];
result = [];
for (var i=0; i<1000; i++) {
var obj = {};
var exp = [];
for (var j=0; j<10; j++) {
obj['key-'+i+'-'+j] = 'property-'+i+'-'+j;
exp[j] = ['key-'+i+'-'+j, 'property-'+i+'-'+j];
}
object[i] = obj;
expected[i] = exp;
}
}
function BasicMegamorphicTearDown() {
if (JSON.stringify(expected) !== JSON.stringify(result)) {
throw new Error("FAILURE");
}
object = result = expected = undefined;
return true;
}
......@@ -4,7 +4,10 @@
load('../base.js');
load('assign.js');
load('values.js');
load('entries.js');
var success = true;
......
// Copyright 2016 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
new BenchmarkSuite('Values', [1000], [
new Benchmark('Basic', false, false, 0, Basic, BasicSetup, BasicTearDown),
]);
var object;
var expected;
var result;
var symbol1;
function Basic() {
result = Object.values(object);
}
function BasicSetup() {
result = undefined;
symbol1 = Symbol('test');
object = { a: 10 };
object[26.0] = 'third';
object.b = 72;
object[symbol1] = 'TEST';
Object.defineProperty(object, 'not-enumerable', {
enumerable: false, value: 'nope', writable: true, configurable: true });
}
function BasicTearDown() {
return result.length === 3 && result[0] === 10 && result[1] === 'third' &&
result[2] === 72;
}
// ----------------------------------------------------------------------------
new BenchmarkSuite('ValuesMegamorphic', [1000], [
new Benchmark('BasicMegamorphic', false, false, 0, BasicMegamorphic,
BasicMegamorphicSetup, BasicMegamorphicTearDown)
]);
function BasicMegamorphic() {
for (var i = 0; i < object.length; ++i) {
result[i] = Object.values(object[i]);
}
}
function BasicMegamorphicSetup() {
// Create 1k objects with different maps.
object = [];
expected = [];
result = [];
for (var i=0; i<1000; i++) {
var obj = {};
var exp = [];
for (var j=0; j<10; j++) {
obj['key-'+i+'-'+j] = 'property-'+i+'-'+j;
exp[j] = 'property-'+i+'-'+j;
}
object[i] = obj;
expected[i] = exp;
}
}
function BasicMegamorphicTearDown() {
if (JSON.stringify(expected) !== JSON.stringify(result)) {
throw new Error("FAILURE");
}
object = result = expected = undefined;
return true;
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment