[turbofan] disable load-elimination overlapping fields check in release mode

Bug: chromium:996097
Change-Id: I2d3bb6e1b844c1ffae0a5e44b1125593402fb7be
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806675
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63798}

src/compiler/load-elimination.cc

@@ -662,16 +662,14 @@ LoadElimination::FieldInfo const* LoadElimination::AbstractState::LookupField(
     if (!result.has_value()) {
       result = info;
     } else {
-      if (**result != *info) {
-        // We detected a partially overlapping access here.
-        // We currently don't seem to have such accesses, so this code path is
-        // unreachable, but if we eventually have them, it is safe to return
-        // nullptr and continue the analysis. But store-store elimination is
-        // currently unsafe for such overlapping accesses, so when we remove
-        // this UNREACHABLE(), we should double-check that store-store
-        // elimination can handle it too.
-        UNREACHABLE();
-      }
+      // We detected a partially overlapping access here.
+      // We currently don't seem to have such accesses, so this code path is
+      // unreachable, but if we eventually have them, it is safe to return
+      // nullptr and continue the analysis. But store-store elimination is
+      // currently unsafe for such overlapping accesses, so when we remove
+      // this check, we should double-check that store-store elimination can
+      // handle it too.
+      DCHECK_EQ(**result, *info);
     }
   }
   return *result;