Add icu libraries to unittests dependencies

In component build, unittests did not link with icu libraries, which
caused errors. By adding icu libraries to dependencies unittests links
correctly.

BUG=
TEST=unittests/*

Review-Url: https://codereview.chromium.org/2479863002
Cr-Commit-Position: refs/heads/master@{#40955}

BUILD.gn

@@ -43,10 +43,6 @@ declare_args() {
   # Sets -dENABLE_HANDLE_ZAPPING.
   v8_enable_handle_zapping = true
 
-  # Enable ECMAScript Internationalization API. Enabling this feature will
-  # add a dependency on the ICU library.
-  v8_enable_i18n_support = true
-
   # Enable slow dchecks.
   v8_enable_slow_dchecks = false
 

gni/v8.gni

@@ -26,6 +26,10 @@ declare_args() {
   # Use external files for startup data blobs:
   # the JS builtins sources and the start snapshot.
   v8_use_external_startup_data = ""
+
+  # Enable ECMAScript Internationalization API. Enabling this feature will
+  # add a dependency on the ICU library.
+  v8_enable_i18n_support = true
 }
 
 if (v8_use_external_startup_data == "") {

test/unittests/BUILD.gn

@@ -172,6 +172,10 @@ v8_executable("unittests") {
     "//testing/gtest",
   ]
 
+  if (v8_enable_i18n_support) {
+    deps += [ "//third_party/icu" ]
+  }
+
   if (is_win) {
     # This warning is benignly triggered by the U16 and U32 macros in
     # bytecode-utils.h.

test/unittests/unittests.gyp

@@ -231,6 +231,12 @@
         ['OS=="aix"', {
           'ldflags': [ '-Wl,-bbigtoc' ],
         }],
+        ['v8_enable_i18n_support==1', {
+          'dependencies': [
+            '<(icu_gyp_path):icui18n',
+            '<(icu_gyp_path):icuuc',
+          ],
+        }],
         ['os_posix == 1', {
           # TODO(svenpanne): This is a temporary work-around to fix the warnings
           # that show up because we use -std=gnu++0x instead of -std=c++11.