Commit 6f265b7c authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[turbofan] Remove misleading broker message

In inlining heuristics, we used to warn about a missing bytecode array
when the actual reason for not inlining the function might have been a
different one (and was printed earlier already).

Bug: v8:7790
Change-Id: I3a44fd793d9b1edc80cd215a8110aa47eee731d4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863934Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64378}
parent 83f8464f
......@@ -143,20 +143,6 @@ Reduction JSInliningHeuristic::Reduce(Node* node) {
Handle<SharedFunctionInfo> frame_shared_info;
for (int i = 0; i < candidate.num_functions; ++i) {
if (!candidate.bytecode[i].has_value()) {
// Can't inline without bytecode.
// TODO(neis): Should this even be a broker message?
if (candidate.functions[i].has_value()) {
TRACE_BROKER(broker(),
"Missing bytecode array trying to inline JSFunction "
<< *candidate.functions[i]);
} else {
TRACE_BROKER(
broker(),
"Missing bytecode array trying to inline SharedFunctionInfo "
<< *candidate.shared_info);
}
// Those functions that don't have their bytecode serialized probably
// don't have the SFI either, so we exit the loop early.
candidate.can_inline_function[i] = false;
continue;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment