Commit 6e13ca6d authored by Jakob Kummerow's avatar Jakob Kummerow Committed by Commit Bot

[cleanup] Delete unused code in codegen*.cc

Bug: v8:6409
Change-Id: I2902d9ad87bab3559c776593ca99d275eeaca8c0
Reviewed-on: https://chromium-review.googlesource.com/622411Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47484}
parent 1785fc36
...@@ -298,24 +298,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) { ...@@ -298,24 +298,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) {
#undef __ #undef __
// -------------------------------------------------------------------------
// Platform-specific RuntimeCallHelper functions.
void StubRuntimeCallHelper::BeforeCall(MacroAssembler* masm) const {
masm->EnterFrame(StackFrame::INTERNAL);
DCHECK(!masm->has_frame());
masm->set_has_frame(true);
}
void StubRuntimeCallHelper::AfterCall(MacroAssembler* masm) const {
masm->LeaveFrame(StackFrame::INTERNAL);
DCHECK(masm->has_frame());
masm->set_has_frame(false);
}
// ------------------------------------------------------------------------- // -------------------------------------------------------------------------
// Code generators // Code generators
......
...@@ -21,24 +21,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) { ...@@ -21,24 +21,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) {
return nullptr; return nullptr;
} }
// -------------------------------------------------------------------------
// Platform-specific RuntimeCallHelper functions.
void StubRuntimeCallHelper::BeforeCall(MacroAssembler* masm) const {
masm->EnterFrame(StackFrame::INTERNAL);
DCHECK(!masm->has_frame());
masm->set_has_frame(true);
}
void StubRuntimeCallHelper::AfterCall(MacroAssembler* masm) const {
masm->LeaveFrame(StackFrame::INTERNAL);
DCHECK(masm->has_frame());
masm->set_has_frame(false);
}
// ------------------------------------------------------------------------- // -------------------------------------------------------------------------
// Code generators // Code generators
......
...@@ -465,24 +465,6 @@ class TurboFanCodeStub : public CodeStub { ...@@ -465,24 +465,6 @@ class TurboFanCodeStub : public CodeStub {
DEFINE_CODE_STUB_BASE(TurboFanCodeStub, CodeStub); DEFINE_CODE_STUB_BASE(TurboFanCodeStub, CodeStub);
}; };
// Helper interface to prepare to/restore after making runtime calls.
class RuntimeCallHelper {
public:
virtual ~RuntimeCallHelper() {}
virtual void BeforeCall(MacroAssembler* masm) const = 0;
virtual void AfterCall(MacroAssembler* masm) const = 0;
protected:
RuntimeCallHelper() {}
private:
DISALLOW_COPY_AND_ASSIGN(RuntimeCallHelper);
};
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8
...@@ -509,30 +491,6 @@ class RuntimeCallHelper { ...@@ -509,30 +491,6 @@ class RuntimeCallHelper {
namespace v8 { namespace v8 {
namespace internal { namespace internal {
// RuntimeCallHelper implementation used in stubs: enters/leaves a
// newly created internal frame before/after the runtime call.
class StubRuntimeCallHelper : public RuntimeCallHelper {
public:
StubRuntimeCallHelper() {}
void BeforeCall(MacroAssembler* masm) const override;
void AfterCall(MacroAssembler* masm) const override;
};
// Trivial RuntimeCallHelper implementation.
class NopRuntimeCallHelper : public RuntimeCallHelper {
public:
NopRuntimeCallHelper() {}
void BeforeCall(MacroAssembler* masm) const override {}
void AfterCall(MacroAssembler* masm) const override {}
};
class StringLengthStub : public TurboFanCodeStub { class StringLengthStub : public TurboFanCodeStub {
public: public:
explicit StringLengthStub(Isolate* isolate) : TurboFanCodeStub(isolate) {} explicit StringLengthStub(Isolate* isolate) : TurboFanCodeStub(isolate) {}
......
...@@ -69,21 +69,6 @@ UNARY_MATH_FUNCTION(sqrt, CreateSqrtFunction) ...@@ -69,21 +69,6 @@ UNARY_MATH_FUNCTION(sqrt, CreateSqrtFunction)
#undef UNARY_MATH_FUNCTION #undef UNARY_MATH_FUNCTION
#ifdef DEBUG
Comment::Comment(Assembler* assembler, const char* msg)
: assembler_(assembler), msg_(msg) {
assembler_->RecordComment(msg);
}
Comment::~Comment() {
if (msg_[0] == '[') assembler_->RecordComment("]");
}
#endif // DEBUG
void CodeGenerator::MakeCodePrologue(ParseInfo* parse_info, void CodeGenerator::MakeCodePrologue(ParseInfo* parse_info,
CompilationInfo* info, const char* kind) { CompilationInfo* info, const char* kind) {
bool print_ast = false; bool print_ast = false;
......
...@@ -13,24 +13,6 @@ ...@@ -13,24 +13,6 @@
namespace v8 { namespace v8 {
namespace internal { namespace internal {
// -------------------------------------------------------------------------
// Platform-specific RuntimeCallHelper functions.
void StubRuntimeCallHelper::BeforeCall(MacroAssembler* masm) const {
masm->EnterFrame(StackFrame::INTERNAL);
DCHECK(!masm->has_frame());
masm->set_has_frame(true);
}
void StubRuntimeCallHelper::AfterCall(MacroAssembler* masm) const {
masm->LeaveFrame(StackFrame::INTERNAL);
DCHECK(masm->has_frame());
masm->set_has_frame(false);
}
#define __ masm. #define __ masm.
......
...@@ -187,30 +187,6 @@ class NoCurrentFrameScope { ...@@ -187,30 +187,6 @@ class NoCurrentFrameScope {
bool saved_; bool saved_;
}; };
// Support for "structured" code comments.
#ifdef DEBUG
class Comment {
public:
Comment(Assembler* assembler, const char* msg);
~Comment();
private:
Assembler* assembler_;
const char* msg_;
};
#else
class Comment {
public:
Comment(Assembler*, const char*) {}
};
#endif // DEBUG
// Wrapper class for passing expected and actual parameter counts as // Wrapper class for passing expected and actual parameter counts as
// either registers or immediate values. Used to make sure that the // either registers or immediate values. Used to make sure that the
// caller provides exactly the expected number of parameters to the // caller provides exactly the expected number of parameters to the
......
...@@ -582,24 +582,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) { ...@@ -582,24 +582,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) {
#undef __ #undef __
// -------------------------------------------------------------------------
// Platform-specific RuntimeCallHelper functions.
void StubRuntimeCallHelper::BeforeCall(MacroAssembler* masm) const {
masm->EnterFrame(StackFrame::INTERNAL);
DCHECK(!masm->has_frame());
masm->set_has_frame(true);
}
void StubRuntimeCallHelper::AfterCall(MacroAssembler* masm) const {
masm->LeaveFrame(StackFrame::INTERNAL);
DCHECK(masm->has_frame());
masm->set_has_frame(false);
}
// ------------------------------------------------------------------------- // -------------------------------------------------------------------------
// Code generators // Code generators
......
...@@ -584,24 +584,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) { ...@@ -584,24 +584,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) {
#undef __ #undef __
// -------------------------------------------------------------------------
// Platform-specific RuntimeCallHelper functions.
void StubRuntimeCallHelper::BeforeCall(MacroAssembler* masm) const {
masm->EnterFrame(StackFrame::INTERNAL);
DCHECK(!masm->has_frame());
masm->set_has_frame(true);
}
void StubRuntimeCallHelper::AfterCall(MacroAssembler* masm) const {
masm->LeaveFrame(StackFrame::INTERNAL);
DCHECK(masm->has_frame());
masm->set_has_frame(false);
}
// ------------------------------------------------------------------------- // -------------------------------------------------------------------------
// Code generators // Code generators
......
...@@ -51,24 +51,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) { ...@@ -51,24 +51,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) {
#undef __ #undef __
// -------------------------------------------------------------------------
// Platform-specific RuntimeCallHelper functions.
void StubRuntimeCallHelper::BeforeCall(MacroAssembler* masm) const {
masm->EnterFrame(StackFrame::INTERNAL);
DCHECK(!masm->has_frame());
masm->set_has_frame(true);
}
void StubRuntimeCallHelper::AfterCall(MacroAssembler* masm) const {
masm->LeaveFrame(StackFrame::INTERNAL);
DCHECK(masm->has_frame());
masm->set_has_frame(false);
}
// ------------------------------------------------------------------------- // -------------------------------------------------------------------------
// Code generators // Code generators
......
...@@ -47,21 +47,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) { ...@@ -47,21 +47,6 @@ UnaryMathFunctionWithIsolate CreateSqrtFunction(Isolate* isolate) {
#undef __ #undef __
// -------------------------------------------------------------------------
// Platform-specific RuntimeCallHelper functions.
void StubRuntimeCallHelper::BeforeCall(MacroAssembler* masm) const {
masm->EnterFrame(StackFrame::INTERNAL);
DCHECK(!masm->has_frame());
masm->set_has_frame(true);
}
void StubRuntimeCallHelper::AfterCall(MacroAssembler* masm) const {
masm->LeaveFrame(StackFrame::INTERNAL);
DCHECK(masm->has_frame());
masm->set_has_frame(false);
}
// ------------------------------------------------------------------------- // -------------------------------------------------------------------------
// Code generators // Code generators
......
...@@ -13,23 +13,6 @@ ...@@ -13,23 +13,6 @@
namespace v8 { namespace v8 {
namespace internal { namespace internal {
// -------------------------------------------------------------------------
// Platform-specific RuntimeCallHelper functions.
void StubRuntimeCallHelper::BeforeCall(MacroAssembler* masm) const {
masm->EnterFrame(StackFrame::INTERNAL);
DCHECK(!masm->has_frame());
masm->set_has_frame(true);
}
void StubRuntimeCallHelper::AfterCall(MacroAssembler* masm) const {
masm->LeaveFrame(StackFrame::INTERNAL);
DCHECK(masm->has_frame());
masm->set_has_frame(false);
}
#define __ masm. #define __ masm.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment