Commit 6de9439f authored by adamk's avatar adamk Committed by Commit bot

Use arraysize() instead of hardcoded kSize constants in api-natives.cc

R=gsathya@chromium.org

Review-Url: https://codereview.chromium.org/2407313003
Cr-Commit-Position: refs/heads/master@{#40187}
parent 9d2051fc
...@@ -533,24 +533,22 @@ MaybeHandle<JSObject> ApiNatives::InstantiateRemoteObject( ...@@ -533,24 +533,22 @@ MaybeHandle<JSObject> ApiNatives::InstantiateRemoteObject(
void ApiNatives::AddDataProperty(Isolate* isolate, Handle<TemplateInfo> info, void ApiNatives::AddDataProperty(Isolate* isolate, Handle<TemplateInfo> info,
Handle<Name> name, Handle<Object> value, Handle<Name> name, Handle<Object> value,
PropertyAttributes attributes) { PropertyAttributes attributes) {
const int kSize = 3;
PropertyDetails details(attributes, DATA, 0, PropertyCellType::kNoCell); PropertyDetails details(attributes, DATA, 0, PropertyCellType::kNoCell);
auto details_handle = handle(details.AsSmi(), isolate); auto details_handle = handle(details.AsSmi(), isolate);
Handle<Object> data[kSize] = {name, details_handle, value}; Handle<Object> data[] = {name, details_handle, value};
AddPropertyToPropertyList(isolate, info, kSize, data); AddPropertyToPropertyList(isolate, info, arraysize(data), data);
} }
void ApiNatives::AddDataProperty(Isolate* isolate, Handle<TemplateInfo> info, void ApiNatives::AddDataProperty(Isolate* isolate, Handle<TemplateInfo> info,
Handle<Name> name, v8::Intrinsic intrinsic, Handle<Name> name, v8::Intrinsic intrinsic,
PropertyAttributes attributes) { PropertyAttributes attributes) {
const int kSize = 4;
auto value = handle(Smi::FromInt(intrinsic), isolate); auto value = handle(Smi::FromInt(intrinsic), isolate);
auto intrinsic_marker = isolate->factory()->true_value(); auto intrinsic_marker = isolate->factory()->true_value();
PropertyDetails details(attributes, DATA, 0, PropertyCellType::kNoCell); PropertyDetails details(attributes, DATA, 0, PropertyCellType::kNoCell);
auto details_handle = handle(details.AsSmi(), isolate); auto details_handle = handle(details.AsSmi(), isolate);
Handle<Object> data[kSize] = {name, intrinsic_marker, details_handle, value}; Handle<Object> data[] = {name, intrinsic_marker, details_handle, value};
AddPropertyToPropertyList(isolate, info, kSize, data); AddPropertyToPropertyList(isolate, info, arraysize(data), data);
} }
...@@ -560,11 +558,10 @@ void ApiNatives::AddAccessorProperty(Isolate* isolate, ...@@ -560,11 +558,10 @@ void ApiNatives::AddAccessorProperty(Isolate* isolate,
Handle<FunctionTemplateInfo> getter, Handle<FunctionTemplateInfo> getter,
Handle<FunctionTemplateInfo> setter, Handle<FunctionTemplateInfo> setter,
PropertyAttributes attributes) { PropertyAttributes attributes) {
const int kSize = 4;
PropertyDetails details(attributes, ACCESSOR, 0, PropertyCellType::kNoCell); PropertyDetails details(attributes, ACCESSOR, 0, PropertyCellType::kNoCell);
auto details_handle = handle(details.AsSmi(), isolate); auto details_handle = handle(details.AsSmi(), isolate);
Handle<Object> data[kSize] = {name, details_handle, getter, setter}; Handle<Object> data[] = {name, details_handle, getter, setter};
AddPropertyToPropertyList(isolate, info, kSize, data); AddPropertyToPropertyList(isolate, info, arraysize(data), data);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment