Fix assertSame for unit testing harness.

Using isNaN() here is bogus because it performs an implicit toNumber()
conversion, hence something like assertSame(undefined, {}) would not
throw an exception. These are not the NaNs you are looking for.

R=rossberg@chromium.org
TEST=mjsunit

Review URL: http://codereview.chromium.org/8400056

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9831 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 9fd8930a
...@@ -223,7 +223,7 @@ var assertUnreachable; ...@@ -223,7 +223,7 @@ var assertUnreachable;
assertSame = function assertSame(expected, found, name_opt) { assertSame = function assertSame(expected, found, name_opt) {
if (found === expected) { if (found === expected) {
if (expected !== 0 || (1 / expected) == (1 / found)) return; if (expected !== 0 || (1 / expected) == (1 / found)) return;
} else if (isNaN(expected) && isNaN(found)) { } else if ((expected !== expected) && (found !== found)) {
return; return;
} }
fail(PrettyPrint(expected), found, name_opt); fail(PrettyPrint(expected), found, name_opt);
......
...@@ -32,6 +32,7 @@ bugs: FAIL ...@@ -32,6 +32,7 @@ bugs: FAIL
############################################################################## ##############################################################################
# Fails. # Fails.
harmony/proxies-function: FAIL
regress/regress-1119: FAIL regress/regress-1119: FAIL
############################################################################## ##############################################################################
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment