Commit 6bcbb8f3 authored by Florian Sattler's avatar Florian Sattler Committed by Commit Bot

[cleanup] Refactor debug to use default members.

Fixing clang-tidy warning.

Bug: v8:8015
Change-Id: I1fdd9210d92725701f413ff410e3a39d96bccf66
Reviewed-on: https://chromium-review.googlesource.com/1224111
Commit-Queue: Florian Sattler <sattlerf@google.com>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55986}
parent d898fa3e
......@@ -63,7 +63,7 @@ class Coverage : public std::vector<CoverageScript> {
static std::unique_ptr<Coverage> Collect(
Isolate* isolate, v8::debug::Coverage::Mode collectionMode);
Coverage() {}
Coverage() = default;
};
} // namespace internal
......
......@@ -156,7 +156,7 @@ MaybeLocal<UnboundScript> CompileInspectorScript(Isolate* isolate,
class DebugDelegate {
public:
virtual ~DebugDelegate() {}
virtual ~DebugDelegate() = default;
virtual void ScriptCompiled(v8::Local<Script> script, bool is_live_edited,
bool has_compile_error) {}
// |inspector_break_points_hit| contains id of breakpoints installed with
......@@ -179,7 +179,7 @@ void SetDebugDelegate(Isolate* isolate, DebugDelegate* listener);
class AsyncEventDelegate {
public:
virtual ~AsyncEventDelegate() {}
virtual ~AsyncEventDelegate() = default;
virtual void AsyncEventOccurred(debug::DebugAsyncActionType type, int id,
bool is_blackboxed) = 0;
};
......
......@@ -35,7 +35,7 @@ DebugStackTraceIterator::DebugStackTraceIterator(Isolate* isolate, int index)
for (; !Done() && index > 0; --index) Advance();
}
DebugStackTraceIterator::~DebugStackTraceIterator() {}
DebugStackTraceIterator::~DebugStackTraceIterator() = default;
bool DebugStackTraceIterator::Done() const { return iterator_.done(); }
......
......@@ -36,7 +36,7 @@ class TypeProfile : public std::vector<TypeProfileScript> {
static void SelectMode(Isolate* isolate, debug::TypeProfile::Mode mode);
private:
TypeProfile() {}
TypeProfile() = default;
};
} // namespace internal
......
......@@ -60,7 +60,7 @@ struct WasmDisassemblyOffsetTableEntry {
struct WasmDisassembly {
using OffsetTable = std::vector<WasmDisassemblyOffsetTableEntry>;
WasmDisassembly() {}
WasmDisassembly() = default;
WasmDisassembly(std::string disassembly, OffsetTable offset_table)
: disassembly(std::move(disassembly)),
offset_table(std::move(offset_table)) {}
......
......@@ -3003,7 +3003,7 @@ int event_listener_hit_count = 0;
class EmptyExternalStringResource : public v8::String::ExternalStringResource {
public:
EmptyExternalStringResource() { empty_[0] = 0; }
~EmptyExternalStringResource() override {}
~EmptyExternalStringResource() override = default;
size_t length() const override { return empty_.length(); }
const uint16_t* data() const override { return empty_.start(); }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment