Commit 6a4bd4c1 authored by Pierre Langlois's avatar Pierre Langlois Committed by Commit Bot

[instruction-scheduler] Do not re-order nodes around kArchDebugBreak.

When debugging CSA builtins, it's useful to place a 'DebugBreak();' in the
code. However, the instruction scheduler re-orders instructions around it which
can be a little frustrating.

Change-Id: Ic4288bbc24e78987c7cbf3616e80cf5915f474c4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1916602Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
Cr-Commit-Position: refs/heads/master@{#64963}
parent bcb78e6c
...@@ -311,9 +311,11 @@ int InstructionScheduler::GetInstructionFlags(const Instruction* instr) const { ...@@ -311,9 +311,11 @@ int InstructionScheduler::GetInstructionFlags(const Instruction* instr) const {
case kArchTailCallAddress: case kArchTailCallAddress:
case kArchTailCallWasm: case kArchTailCallWasm:
case kArchAbortCSAAssert: case kArchAbortCSAAssert:
case kArchDebugBreak:
return kHasSideEffect; return kHasSideEffect;
case kArchDebugBreak:
return kIsBarrier;
case kArchSaveCallerRegisters: case kArchSaveCallerRegisters:
case kArchRestoreCallerRegisters: case kArchRestoreCallerRegisters:
return kIsBarrier; return kIsBarrier;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment