Commit 69ad35ac authored by kozyatinskiy's avatar kozyatinskiy Committed by Commit bot

[inspector] follow up for e27d18c9

- renamed inspector-test methods,
- tuned comment in debug.h

BUG=v8:6118
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2766283002
Cr-Commit-Position: refs/heads/master@{#44043}
parent 681e3312
...@@ -566,7 +566,8 @@ class Debug { ...@@ -566,7 +566,8 @@ class Debug {
// Step action for last step performed. // Step action for last step performed.
StepAction last_step_action_; StepAction last_step_action_;
// If set then this function will be ignored in PrepareStepIn call. // If set, next PrepareStepIn will ignore this function until stepped into
// another function, at which point this will be cleared.
Object* ignore_step_into_function_; Object* ignore_step_into_function_;
// If set then we need to repeat StepOut action at return. // If set then we need to repeat StepOut action at return.
......
...@@ -5,11 +5,11 @@ ...@@ -5,11 +5,11 @@
InspectorTest.log('Checks stepping over tail calls.'); InspectorTest.log('Checks stepping over tail calls.');
InspectorTest.setupScriptMap(); InspectorTest.setupScriptMap();
InspectorTest.dumpProtocolCommand('Debugger.pause'); InspectorTest.logProtocolCommandCalls('Debugger.pause');
InspectorTest.dumpProtocolCommand('Debugger.stepInto'); InspectorTest.logProtocolCommandCalls('Debugger.stepInto');
InspectorTest.dumpProtocolCommand('Debugger.stepOver'); InspectorTest.logProtocolCommandCalls('Debugger.stepOver');
InspectorTest.dumpProtocolCommand('Debugger.stepOut'); InspectorTest.logProtocolCommandCalls('Debugger.stepOut');
InspectorTest.dumpProtocolCommand('Debugger.resume'); InspectorTest.logProtocolCommandCalls('Debugger.resume');
let source = ` let source = `
function f(x) { function f(x) {
......
...@@ -12,11 +12,11 @@ function callAll() { ...@@ -12,11 +12,11 @@ function callAll() {
//# sourceURL=framework.js`); //# sourceURL=framework.js`);
InspectorTest.setupScriptMap(); InspectorTest.setupScriptMap();
InspectorTest.dumpProtocolCommand('Debugger.pause'); InspectorTest.logProtocolCommandCalls('Debugger.pause');
InspectorTest.dumpProtocolCommand('Debugger.stepInto'); InspectorTest.logProtocolCommandCalls('Debugger.stepInto');
InspectorTest.dumpProtocolCommand('Debugger.stepOver'); InspectorTest.logProtocolCommandCalls('Debugger.stepOver');
InspectorTest.dumpProtocolCommand('Debugger.stepOut'); InspectorTest.logProtocolCommandCalls('Debugger.stepOut');
InspectorTest.dumpProtocolCommand('Debugger.resume'); InspectorTest.logProtocolCommandCalls('Debugger.resume');
Protocol.Debugger.enable(); Protocol.Debugger.enable();
Protocol.Debugger.setBlackboxPatterns({patterns: ['framework\.js']}); Protocol.Debugger.setBlackboxPatterns({patterns: ['framework\.js']});
......
...@@ -7,7 +7,7 @@ InspectorTest._dispatchTable = new Map(); ...@@ -7,7 +7,7 @@ InspectorTest._dispatchTable = new Map();
InspectorTest._requestId = 0; InspectorTest._requestId = 0;
InspectorTest._dumpInspectorProtocolMessages = false; InspectorTest._dumpInspectorProtocolMessages = false;
InspectorTest._eventHandler = {}; InspectorTest._eventHandler = {};
InspectorTest._commandToLog = new Set(); InspectorTest._commandsForLogging = new Set();
Protocol = new Proxy({}, { Protocol = new Proxy({}, {
get: function(target, agentName, receiver) { get: function(target, agentName, receiver) {
...@@ -31,7 +31,7 @@ Protocol = new Proxy({}, { ...@@ -31,7 +31,7 @@ Protocol = new Proxy({}, {
} }
}); });
InspectorTest.dumpProtocolCommand = (command) => InspectorTest._commandToLog.add(command); InspectorTest.logProtocolCommandCalls = (command) => InspectorTest._commandsForLogging.add(command);
var utils = {}; var utils = {};
(function setupUtils() { (function setupUtils() {
...@@ -268,7 +268,7 @@ InspectorTest._sendCommandPromise = function(method, params, contextGroupId) ...@@ -268,7 +268,7 @@ InspectorTest._sendCommandPromise = function(method, params, contextGroupId)
var messageObject = { "id": requestId, "method": method, "params": params }; var messageObject = { "id": requestId, "method": method, "params": params };
var fulfillCallback; var fulfillCallback;
var promise = new Promise(fulfill => fulfillCallback = fulfill); var promise = new Promise(fulfill => fulfillCallback = fulfill);
if (InspectorTest._commandToLog.has(method)) { if (InspectorTest._commandsForLogging.has(method)) {
utils.print(method + ' called'); utils.print(method + ' called');
} }
InspectorTest.sendRawCommand(requestId, JSON.stringify(messageObject), fulfillCallback, contextGroupId); InspectorTest.sendRawCommand(requestId, JSON.stringify(messageObject), fulfillCallback, contextGroupId);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment